GNOME Bugzilla – Bug 322874
[PAD] pad_alloc_buffer should not call set_caps
Last modified: 2005-12-05 13:05:20 UTC
pad_alloc_buffer currently calls the setcaps function when a buffer with
different caps was allocated by the downstream peer element. The problem with
this is that it makes writing certain plugins much harder as they might not be
able to renegotiate at that time, specifically basetransform.
Damn you wim, we should have gotten this in last week. Why did you let it sit
this long? And what should we do about it?
Created attachment 55623 [details] [review]
pad to add new function with old behaviour
This patch adds a gst_pad_alloc_buffer_and_set_caps that has the old behaviour.
Created attachment 55625 [details]
Script to sed the plugins
Run this script on all C files to change calls from alloc_buffer to
ok to commit *PROVIDED* that the documentation is updated *correctly* (ie, both
need to show up in the output of gtk-doc, which with the current patch is not
Created attachment 55630 [details] [review]
Totally in now.