GNOME Bugzilla – Bug 312706
[PATCH] find/replace dialog erase selection once closed
Last modified: 2020-11-24 09:59:39 UTC
Please describe the problem: Steps to reproduce: 1. highlight a text 2. ctrl-f 3. The entry grabs the focus, and gets highlighted, thus erasing the buffer's selection 4. close the find dialog Actual results: The buffer has no more selection Expected results: The buffer should keep original selection Does this happen every time? Yes Other information: The provided patch restores the selection after showing the find dialog. The entry isn't highlighted anymore, but it has the focus at end of text.
Created attachment 50289 [details] [review] gedit find/replace dialog patch See above
Created attachment 51516 [details] [review] Patch v.2 This is a slighty modified version of the previous patch with some cosmetic changes. It also sets the cursor position of the search entry to 0. I'm not going to commit this patch now for two reasons: - today code freeze for 2.12.0 begins - I'm not too sure I like the new behavior. I discussed this bug with pbor on IRC and we have seen a few cases where the new behavior is needed (but I'm not sure they are so important). Testing this patch, the new behavior gives me a strange feeling... I don't like very much the fact the search string is not selected when some text is selected in the editor window. Please, try the attached patch and report your feelings :)
I must admit i like this new behavior :)
Mass-closing of all gedit bugzilla tickets. Special "code" to find again all those gedit bugzilla tickets that were open before the mass-closing: 2bfe1b0590a78457e1f1a6a90fb975f5878cb60064ccfe1d7db76ca0da52f0f3 By searching the above sha256sum in bugzilla, the gedit contributors can find again the tickets. We may be interested to do so when we work on a specific area of the code, to at least know the known problems and possible enhancements. We do this mass-closing because bugzilla.gnome.org is being replaced by gitlab.gnome.org.