After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303570 - dialogs should be in a separate window group
dialogs should be in a separate window group
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-09 15:25 UTC by Matthias Clasen
Modified: 2005-05-11 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
panel-no-window-group-for-you.patch (2.74 KB, patch)
2005-05-11 08:39 UTC, Mark McLoughlin
none Details | Review

Description Matthias Clasen 2005-05-09 15:25:19 UTC
The dialogs created by the panel, e.g. the "Add to panel" dialog or the about
boxes, are currently in the same window group as the panel itself. This causes
metacity to refuse to raise any window on top of them, although they're not
modal. The behaviour feels quite broken. I can move the keyboard focus from the 
"Add to panel" dialog to another window, but I can't raise that window over the
dialog. Even more annoying is if usermode (the RH root password dialog) or the
keyboard a11y warning dialogs pop under.

Please consider putting the dialogs in a separate window group. 
"xprop -remove WM_HINTS" on the "Add to panel" dialog confirms that that 
should be enough to fix the issue.
Comment 1 Mark McLoughlin 2005-05-11 08:39:13 UTC
Created attachment 46321 [details] [review]
panel-no-window-group-for-you.patch

So, the panel seems to have had code to try and unset the group leader forever
now:

Sat Apr 29 13:30:11 2000  George Lebl <jirka@5z.com>

	* xstuff.[ch] (xstuff_set_no_group):  Add this call, it unsets the
	  group hint for a window.  This makes the panels not part of the
	  same group as the dialogs meaning they won't get minimized with
	  the "group"


i.e. rather than leave the panels in the default group and create a new group
for dialogs, just make the panels not be part of any group.

Here's a patch that just makes each panel be in its own group (i.e. make itself
the group leader)

Does that sound reasonable?
Comment 2 Mark McLoughlin 2005-05-11 08:52:35 UTC
Okay, committed that:

2005-05-11  Mark McLoughlin  <mark@skynet.ie>

        Fix "dialogs pop up under panel dialogs" issue by
        making each panel be in its own window group and
        the dialogs part of the default group. Bug #303570

        * panel-toplevel.c: (panel_toplevel_realize):
        Just set the group leader to be the panel itself
        rather than making a futile effort to foil gtk.

        * xstuff.[ch]:
        (xstuff_set_no_group): remove.