After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166375 - [PATCH] Best shows null characters in MP3 tags
[PATCH] Best shows null characters in MP3 tags
Product: beagle
Classification: Other
Component: General
Other All
: Normal normal
: Milestone 1
Assigned To: Veerapuram Varadhan
Veerapuram Varadhan
Depends on:
Reported: 2005-02-05 15:38 UTC by Ruben Vermeersch
Modified: 2005-03-15 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Screenshot (76.80 KB, image/png)
2005-02-05 15:38 UTC, Ruben Vermeersch
audioformats.patch (10.39 KB, patch)
2005-02-08 13:50 UTC, Raphael Slinckx
none Details | Review
entagged-sharp-beagle.tar.gz (15.23 KB, application/x-compressed-tar)
2005-02-08 13:53 UTC, Raphael Slinckx
audioformats-multiprop.patch (11.17 KB, patch)
2005-02-08 15:48 UTC, Raphael Slinckx
none Details | Review
entagged+multiprops.patch (22.02 KB, patch)
2005-02-08 23:51 UTC, Raphael Slinckx
none Details | Review
Do not show album as "" when album-tag doesn't exist. (1.21 KB, patch)
2005-03-14 23:37 UTC, Veerapuram Varadhan
none Details | Review

Description Ruben Vermeersch 2005-02-05 15:38:33 UTC
Please describe the problem:
As seen on screenshot, tags are padded with null chars

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Ruben Vermeersch 2005-02-05 15:38:57 UTC
Created attachment 37028 [details]
Comment 2 Raphael Slinckx 2005-02-05 15:42:33 UTC
I provided the filetrs to read audio file tags, bugs have been fixed since then,
I will work on a new version of music tag filters, maybe it will be done this
Comment 3 Raphael Slinckx 2005-02-07 18:55:29 UTC
I managed to finish the update, it has the form of a directory containing the
sources files separated with each format in its subfolder. Is this a problem, or
can I afford a beagle/Util/entagged-sharp directory ? (this will replace the old
Filter{Ape,Mp3,Flac,Mpc,Ogg}.cs and Tag.cs currently in beagle/Util/)
Comment 4 Raphael Slinckx 2005-02-08 13:50:31 UTC
Created attachment 37162 [details] [review]

Patch to update filters to use the new namespaces mainly.
Update the Mp3 reader to correctly use v1 and/or v2.
Update the Music filter to use multiple artists from tags, and miscellaneous
music metadata as well. Won't generate empty properties anymore.

The following files can be removed :

The entagged-sharp package provided below has to be placed in
to match the automake file, feel free to change...
Comment 5 Raphael Slinckx 2005-02-08 13:53:27 UTC
Created attachment 37163 [details]

This is the package containing a slightly stripped version of the entagged
library (the part concerning file infos like bitrate encoding type etc are
removed. If needed can be readded later, also tag writing is removed.)

I will maintain this port on the entagged library java homepage on sourceforge,
and will provide updates when necessary.
Comment 6 Veerapuram Varadhan 2005-02-08 15:09:05 UTC
Raf: The following lines in your patch (FilterMusic.cs, DoPullProperties ()),
requires little change, as you cannot add (guys please correct me if I am wrong)
duplicate keywords.

foreach(TagTextField field in tag.Artist)
  AddProperty (Beagle.Property.New ("fixme:artist",  field.Content));

If the specification of a file allows defining duplicate tags, we can take the
approach like:

For duplicate artists:
  fixme:artist = "<name-of-the-first-artist-available-in-the-tags>"
  fixme:artist-team = "<name-of-the-second-artist> - <name-of-the-third-artist>
- ... - <name-of-the-nth-artist>".

Like this we can have for albums and other tags.

Jon: What do you say?
Comment 7 Raphael Slinckx 2005-02-08 15:48:41 UTC
Created attachment 37178 [details] [review]

Now uses a main property for first item (that will mostly always be present and
be the only value in the tag) and a second property containing other values for
that field if any, concatenated and separated with a defineable separator (" -
" for the moment).

The secondary prop names are not good, they must be changed to something
Comment 8 Raphael Slinckx 2005-02-08 23:51:12 UTC
Created attachment 37219 [details] [review]

This patch will add entagged support like before, but will also add multi
proerties support for beagle, this is a rather deep change in how the API
behaves, but theoretically, backward compatibility is ensured.

Calls to get a property will return the first one or null if none exist
(original behavior), and calls to set a property will erase any existing
property with that name (thus reducing it to a 1 element property).

The above changes are in Hit.cs and LuceneDriver.cs

To handle these new properties in Best, i rewrote the html parser/builder that
best uses (Template.cs) to also use multiple properties internally, again
backward compatibility is ensured.

To use the multipros in the html source a new kind of construct is introduced:

This kind of statement is of the form (on an empty line):

{ <ul> $ <li>@Title@</li> $ </ul> $ @Title@ }

Fields are "$" separated inside it
1- Header
2- Repetitive part
3- Footer
4- Part if there is only one occurence of repetitive part

So in this case, it would output either


if there is only one album title, or

  <li>Anotheralbum title</li>
  <li>Third title</li>

if there are multiple items.
This should allow a wide variety of constructions.

No tiles have been updated yet to use this kind of html, but i will modify the
template-music.html.cs to give a sample.
Comment 9 Veerapuram Varadhan 2005-02-09 06:43:01 UTC
Patch looks good.  Let me try it give more comments. :-)
Comment 10 Veerapuram Varadhan 2005-02-10 17:04:49 UTC
I have tested the patch, it works fine and closes some of the bugs ;-).  It is
in my local tree.  Can you patch template-music.html as well, so that I can
commit all the changes in one go?

Thanks for the patch. ;-)
Comment 11 Nat Friedman 2005-03-09 20:45:30 UTC
Varadhan, is this patch in CVS yet?  Let's close this bug if it is.
Comment 12 Veerapuram Varadhan 2005-03-14 23:37:07 UTC
Created attachment 38717 [details] [review]
Do not show album as "" when album-tag doesn't exist.
Comment 13 Fredrik Hedberg 2005-03-15 23:19:52 UTC