GNOME Bugzilla – Bug 158967
[PATCH] Alert Dialog and Tooltip cleanup
Last modified: 2004-12-22 21:47:04 UTC
I am attaching a patch to HIGify the alert dialogs. This means supporting primary and secondary message text in the dialogs. I also cleaned up the applet's tooltip text.
Created attachment 33991 [details] Example of error dialog before change.
Created attachment 33992 [details] Example of error dialog after change.
Created attachment 33993 [details] Example of error dialog after change.
Created attachment 33994 [details] Example of tooltip after change.
Created attachment 33995 [details] [review] Proposed patch.
I missing one thing. The alerts dialog should use an 'OK' button, not a 'Close' button.
Created attachment 34000 [details] [review] Proposed patch.
Dennis, some thoughs: - attachment 33992 [details] - there should probably be a little more description, I think something like: CPU Frequency Scaling Unsupported You will not be able to modify the frequency of your machine. Your machine may be misconfigured or not have hardware support for CPU Frequency Scaling. Also, we need to make a decision for consistancy about how to name it, Frequency Scaling, Frequency monitoring, Computer Speed Scaling. Something descriptive and simple. Carlos, thoughts?
In this dialog we want to notify that there isn't CPU Frequency Scaling support in the current kernel or system, so I think it should be CPU Frequency Scaling, not monitoring. But there could be several reasons why the cpufreq is not working, maybe it's compiled in the kernel but the /sys fielsystem is not mounted. The dialog should try to explain this situation to the user, but in a user friendly way (I know it's not so easy). I like the davyd suggestion.
I agree with Davyd's wording for the dialog, and I'll rework the patch to use the term CPU Frequency Scaling. Thanks for the feedback.
Created attachment 34239 [details] [review] Updated patch. This patch uses the term 'scaling' rather than 'montor', and rewords the error dialog as discussed above.
Applied in CVS. Thank you again ;-)
Can this bug be closed?
Yes, I haven't closed it yet because I haven't permission
To close bugs?
Yes, I only have the "Leave as . . ." option in all of the bugs.
Hmm, ask for more permissons in #bugs