After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134057 - bonobo file storage and listContents
bonobo file storage and listContents
Product: gnome-vfs
Classification: Deprecated
Component: Other
cvs (head)
Other Linux
: High major
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Reported: 2004-02-10 23:03 UTC by Nickolay V. Shmyrev
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch (1.25 KB, patch)
2004-02-11 15:08 UTC, Nickolay V. Shmyrev
accepted-commit_now Details | Review

Description Nickolay V. Shmyrev 2004-02-10 23:03:20 UTC
Bonobo file storage object doesn't correctly executes listContents method 
of Bonobo::Storage. Instead of getting contents in moniker_path/path it 
returns contents of moniker_path(without addition of path argument). 
For example 
 object = bonobo_get_object ("/home"...); 
 Bonobo_Storage_listContents (object, "/user"); 
will return contents of /home instead of contents of /home/user. 
This is caused by this code from gnome-vfs/moniker/bonobo-storage-fs: 
 if (!(dir = opendir (storage_fs->path))) 
                        goto list_contents_except; 
instead of  
 fullname = concat_dir_and_file (storage_fs->path,path); 
 if (!(dir = opendir (fullname))) 
                        goto list_contents_except;
Comment 1 Nickolay V. Shmyrev 2004-02-11 15:08:32 UTC
Created attachment 24307 [details] [review]
Comment 2 Luis Villa 2004-02-26 19:42:22 UTC
What's the user impact of this problem? why is it high/critical?
Comment 3 Michael Meeks 2004-06-03 17:22:09 UTC
looks fine to commit to me.
Comment 4 Luis Villa 2004-06-06 18:00:06 UTC
Comment on attachment 24307 [details] [review]

Adding accepted-commit_now flag as per michael's comment.
Comment 5 Christophe Fergeau 2004-06-07 21:02:26 UTC
 Nickolay, feel free to commit if you have CVS access
Comment 6 Christophe Fergeau 2004-06-07 21:12:56 UTC
Commmitted to HEAD, thanks for the patch