After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 133653 - need to settle on coding style using indent and use it before 0.8
need to settle on coding style using indent and use it before 0.8
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Urgent minor
: 0.8.0
Assigned To: Thomas Vander Stichele
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-02-06 15:44 UTC by Thomas Vander Stichele
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Vander Stichele 2004-02-06 15:44:33 UTC
* pick a style
* code up the indent rules
* add vim/emacs rules to source files
* do one atomic commit of the diff when run through this
Comment 1 David Schleef 2004-02-06 18:52:17 UTC
#!/bin/sh

indent \
        --braces-on-if-line \
        --blank-lines-after-declarations \
        --case-brace-indentation0 \
        --case-indentation2 \
        --braces-after-struct-decl-line \
        --line-length80 \
        --use-tabs \
        --cuddle-else \
        --dont-line-up-parentheses \
        --continuation-indentation4 \
        --honour-newlines \
        --tab-size8 \
        --indent-level2 \
        $*

.vimrc:

                                                                     
    au BufNewFile,BufRead
/home/ds/gst/*.h,/home/ds/gst/*.c,/home/ds/gst/*.cc
        \ set shiftwidth=2 softtabstop=2 expandtab
Comment 2 Benjamin Otte (Company) 2004-02-06 22:03:08 UTC
How does that work with multiline macros?
I like to put the \ at pos. 81
Comment 3 David Schleef 2004-02-06 23:02:55 UTC
indent doesn't do anything with preprocessor directives, iirc.

I would prefer that no line be longer than 80 characters.  It just
hides problems with no benefit.
Comment 4 David I. Lehn 2004-02-06 23:13:57 UTC
Don't forget we have gstreamer/indent.pro.
Comment 5 Thomas Vander Stichele 2004-02-07 00:43:36 UTC
it's a blocker since 0.8.0 should have it, so patches made from them
on don't break because of indentation issues.
Comment 6 Benjamin Otte (Company) 2004-02-08 12:16:22 UTC
According to http://bugzilla.gnome.org/bug_status.html#severity it's
trivial or minor at best.
Note that priority is used for "when should this be applied?"
Comment 7 Thomas Vander Stichele 2004-02-08 13:12:57 UTC
You are right.  Since you are causing some irritation, you rank as
minor.  A workaround should exist.

Oh, you meant *the bug* ? Sorry, didn't follow.

No, I disagree :)
Comment 8 Thomas Vander Stichele 2004-02-08 16:50:43 UTC
this is just like tennis :)
Comment 9 Thomas Vander Stichele 2004-03-15 22:48:15 UTC
done, fixed