After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119615 - glib-gettext.m4 obsolete macro
glib-gettext.m4 obsolete macro
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: build
2.2.x
Other Linux
: Low normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2003-08-11 08:02 UTC by Steve Chaplin
Modified: 2018-05-24 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to replace AC_OUTPUT_COMMANDS has been obsolete since autoconf 2.50 and Patch to replace AC_CONFIG_COMMANDS (580 bytes, patch)
2003-08-11 08:06 UTC, Steve Chaplin 		needs-work Details | Review

Description Steve Chaplin 2003-08-11 08:02:11 UTC 
Running 'autoreconf -Wall' in a directory containing a configure.ac which
calls AM_GLIB_GNU_GETTEXT gives the warnings:
"configure.ac:42: warning: The macro `AC_OUTPUT_COMMANDS' is obsolete.
You should run autoupdate.
configure.ac:42: warning: The macro `_AC_OUTPUT_COMMANDS_CNT' is obsolete.
You should run autoupdate."

AC_OUTPUT_COMMANDS has been obsolete since autoconf 2.50 and
should be replaced by AC_CONFIG_COMMANDS
Comment 1 Steve Chaplin 2003-08-11 08:06:08 UTC 
Created attachment 19101 [details] [review]
Patch to replace AC_OUTPUT_COMMANDS has been obsolete since autoconf 2.50 and
Patch to replace  AC_CONFIG_COMMANDS
Comment 2 Owen Taylor 2003-08-25 16:10:08 UTC 
Patch looks wrong to me - what the code currently is doing
is a "post-processing" on the

  po/Makefile.in.in => po/Makefile.in 

step that is done with normal substitution. Using a
separate tag for po/Makefile won't catch the logic

 "if po/Makefile.in is regenerated, run this substitution
  and generate po/Makefile"

So, using 'po/Makefile' isn't correct. But you can't 
use po/Makefile.in as the tag either, since you can only
have one rule for a particular tag. Not really sure
how to get the right effect with AC_CONFIG_COMMANDS.

gettext is still using AC_OUTPUT_COMMANDS in po.m4, despite
a lot of other changes.
Comment 3 Benjamin Moody 2012-08-11 21:53:22 UTC 
The real problem here is that the rule in Makefile.in.in is insufficient.  Currently Makefile.in.in contains:

Makefile: Makefile.in.in ../config.status POTFILES
	cd .. \
	  && $(SHELL) ./config.status $(subdir)/$@.in

With current autoconf, this will only regenerate Makefile.in, never Makefile.

So, instead, AM_GLIB_GNU_GETTEXT should use

    AC_CONFIG_COMMANDS([po/Makefile],
      [sed -e "/POTFILES =/r po/POTFILES" po/Makefile.in > po/Makefile])

And Makefile.in.in should use:

Makefile.in: Makefile.in.in ../config.status
	cd .. && $(SHELL) ./config.status $(subdir)/$@

Makefile: Makefile.in ../config.status POTFILES
	cd .. && $(SHELL) ./config.status $(subdir)/$@
Comment 4 GNOME Infrastructure Team 2018-05-24 10:28:48 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/13.