After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 99864 - Remove unnecessary markup from glade messages in gthumb
Remove unnecessary markup from glade messages in gthumb
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on: 97061 589703
Blocks:
 
 
Reported: 2002-11-29 01:54 UTC by Christian Rose
Modified: 2010-01-21 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
changing markup test patch (not committed) (890 bytes, patch)
2010-01-20 14:19 UTC, Matthias Hawran
none Details | Review
fixing all markups (10.80 KB, patch)
2010-01-21 08:29 UTC, Matthias Hawran
none Details | Review

Description Christian Rose 2002-11-29 01:54:29 UTC
#: src/gthumb.glade.h:3
msgid "<b>Categories:</b>"

#: src/gthumb.glade.h:4
msgid "<b>Information on Channel:</b>"

#: src/gthumb.glade.h:5
msgid "<b>Overwrite the old image with the new one?</b>"

#: src/gthumb_convert.glade.h:3
msgid "<b>Compression</b>"

#: src/gthumb_convert.glade.h:4
msgid "<b>Image Type</b>"

#: src/gthumb_convert.glade.h:5
msgid "<b>Resolution</b>"

#: src/gthumb_edit.glade.h:5
msgid "<b>Color levels</b>"

#: src/gthumb_edit.glade.h:6
msgid "<b>New Dimensions</b>"

#: src/gthumb_edit.glade.h:7
msgid "<b>Original Dimensions</b>"

#: src/gthumb_edit.glade.h:8
msgid "<b>Scale Ratio</b>"

#: src/gthumb_png_exporter.glade.h:14
msgid "<b>Background Style</b>"

#: src/gthumb_png_exporter.glade.h:15
msgid "<b>Caption</b>"

#: src/gthumb_png_exporter.glade.h:16
msgid "<b>Destination Folder</b>"

#: src/gthumb_png_exporter.glade.h:17
msgid "<b>Footer</b>"

#: src/gthumb_png_exporter.glade.h:18
msgid "<b>Header and Footer</b>"

#: src/gthumb_png_exporter.glade.h:19
msgid "<b>Header</b>"

#: src/gthumb_png_exporter.glade.h:20
msgid "<b>Index Images</b>"

#: src/gthumb_png_exporter.glade.h:21
msgid "<b>Page Size</b>"

#: src/gthumb_png_exporter.glade.h:22
msgid "<i>Examples:</i>"

#: src/gthumb_preferences.glade.h:13
msgid "<b>Checks</b>"

#: src/gthumb_preferences.glade.h:14
msgid "<b>Direction</b>"

#: src/gthumb_preferences.glade.h:15
msgid "<b>Hide/Show</b>"

#: src/gthumb_preferences.glade.h:16
msgid "<b>History</b>"

#: src/gthumb_preferences.glade.h:17
msgid "<b>Interface</b>"

#: src/gthumb_preferences.glade.h:18
msgid "<b>On Startup:</b>"

#: src/gthumb_preferences.glade.h:19
msgid "<b>Other</b>"

#: src/gthumb_preferences.glade.h:20
msgid "<b>Slide Show</b>"

#: src/gthumb_preferences.glade.h:21 src/gthumb_tools.glade.h:7
msgid "<b>Thumbnails</b>"

#: src/gthumb_preferences.glade.h:22
msgid "<b>Viewer</b>"

#: src/gthumb_print.glade.h:3
msgid ""
"<i>Drag the image to move\n"
"it in the page.</i>"

#: src/gthumb_search.glade.h:4
msgid "<b>Search Criteria</b>"

#: src/gthumb_search.glade.h:5
msgid "<b>Search Scope</b>"

#: src/gthumb_tools.glade.h:4
msgid "<b>Comments</b>"

#: src/gthumb_tools.glade.h:5
msgid "<b>File list</b>"

#: src/gthumb_tools.glade.h:6
msgid "<b>Specify a template to use for renaming images</b>"


This use of markup inside messages marked for translation is totally
unnecessary, and a problem for the translation process. For details, see
the problem description in bug 96836. Since these are glade messages, I'll
mark it dependant on the glade bug 97061 in the mean time.
Comment 1 Niels Weber 2006-12-29 13:56:25 UTC
As these source files don't even exist anymore in recent versions of gthumb, I guess this bug can be closed.
Comment 2 Michael Chudobiak 2006-12-30 21:47:57 UTC
The exact files may have changed, but HTML markup still exists in the *.po files. But there isn't much we can do here until glade changes its behaviour...

- Mike


Comment 3 Matthias Hawran 2010-01-19 13:02:36 UTC
Paolo, Mike,

The 2 bugs this one depended on are closed.
Is this one resolved then?

However I still see markups in po files.

Thank you for taking a look.

Matthias
Comment 4 Paolo Bacchilega 2010-01-19 14:28:08 UTC
no, not yet, but can be easily fixed because glade now allows to set the text attributes
Comment 5 Matthias Hawran 2010-01-20 08:49:57 UTC
Ok, if I can help just let me know how to do it.
I guess I have to open all the *.ui with glade and change something ?
Comment 6 Paolo Bacchilega 2010-01-20 10:05:03 UTC
(In reply to comment #5)
> Ok, if I can help just let me know how to do it.
> I guess I have to open all the *.ui with glade and change something ?

you have to select the label with markup text, remove the markup and set the relative pango attributes.
Comment 7 Matthias Hawran 2010-01-20 14:19:11 UTC
Created attachment 151837 [details] [review]
changing markup test patch (not committed)

Ok, just to make sure I'm going the right way, here's a test update.
Let me know if it's ok, I'll do the full update if it's correct.

Other thing, how do the .po get updated from the .ui ?
It's the translators job to run some script to update the msgid ?
Because many .po still have markups in the msgid,
whereas corresponding .ui is up to date.
(e.g. data/ui/preferences.ui vs po/fr.po => msgid "<b>On startup:</b>")
Comment 8 Michael Chudobiak 2010-01-20 14:27:13 UTC
Translators look after the .po files, you don't need to touch them. It is described here: http://developer.gnome.org/projects/gtp/l10n-guide/.

Specifically, translators: "need to generate a new .pot file which contains all the strings to translate and then to merge it with your xx.po file which has a less up-to-date set of translated strings. Generate the .pot file with intltool-update --pot. Merge the two together with msgmerge -o new-xx.po xx.po .pot"

You can generate the .pot file if you want to check your work.

- Mike
Comment 9 Paolo Bacchilega 2010-01-20 17:36:11 UTC
(In reply to comment #7)
> Created an attachment (id=151837) [details] [review]
> changing markup test patch (not committed)
> 
> Ok, just to make sure I'm going the right way, here's a test update.
> Let me know if it's ok, I'll do the full update if it's correct.
> 

yes, you did it the right way

> Other thing, how do the .po get updated from the .ui ?
> It's the translators job to run some script to update the msgid ?

yes, don't worry about that

> Because many .po still have markups in the msgid,
> whereas corresponding .ui is up to date.
> (e.g. data/ui/preferences.ui vs po/fr.po => msgid "<b>On startup:</b>")
Comment 10 Matthias Hawran 2010-01-21 08:29:41 UTC
Created attachment 151927 [details] [review]
fixing all markups

Ok here's the final patch updating all the remaining markup labels.
I also upgraded the remaining .ui gtk+ requirements from 2.12 to 2.16.
Comment 11 Paolo Bacchilega 2010-01-21 11:16:38 UTC
(In reply to comment #10)
> Created an attachment (id=151927) [details] [review]
> fixing all markups
> 
> Ok here's the final patch updating all the remaining markup labels.
> I also upgraded the remaining .ui gtk+ requirements from 2.12 to 2.16.

patch applied, thanks.