GNOME Bugzilla – Bug 99533
[ui-review] Sound preferences UI issues
Last modified: 2004-12-22 21:47:04 UTC
- "Enable sound server startup" if it does it straight away, it's not really needed at all, you could just turn it on when you checked "sounds for events" - s/File to play/Sound File - Shows sounds that aren't installed on your system if you don't install gnome-audio - HIG Frame stuff - Stripey treeview - Play button looks better to the right of the Browse button - Columns aren't resizable - <calum> there's no obvious way to remove a sound from an event - Sound events should use words from the doc list -- s/Action button click/Click on command button -- s/Check box toggled/Select check box -- s/Menu item activation/Choose menu item -- s/GNOME system events/System events -- s/Error Messages/Error message -- s/Informational Messages/Informational message -- s/Login/Log in -- s/Logout/Log out -- s/Miscellaneous Messages/Miscellaneous message -- s/Question Dailogs/Question dialog -- s/Warning Messages/Warning message -- s/New Mail/New mail - <calum> the categories in the first column don't seem to be ordered in any sane way, and you can't click on the column headers to sort them
From UI-Review 2.0: - List needs label 'Sound:' and mnemonic - Tooltips on the treeview should show full path if clipped - Text entry should have label 'Sound file' and mnemonic - above text entry to allow field to be wider?
*** Bug 85638 has been marked as a duplicate of this bug. ***
Created attachment 12990 [details] [review] (Part 1) The Gnome Control Center patch...
Created attachment 12991 [details] [review] (Part 2) The libgnome patch...
Created attachment 12992 [details] [review] (Part 3) The GNOME Panel patch...
I attached three patches for this bug report as the changes span across three cvs modules: gnome-control-center, libgnome, and gnome-panel. The patch for gnome-control-center addresses these issues... 2002-12-14 Dennis Cranston <dennis_cranston@yahoo.com> * sound-view.c: Fixes for ui-review bug number 99533. - s/File to play/Sound File, - HIG Frame stuff, - Play button looks better to the right of the Browse button, - Columns aren't resizable, - Can't click on the column headers to sort them, - Text entry should have label "Sound File" and mnemonic - above text entry to allow field to be wider. The patch for libgnome addresses these issues... 2002-12-14 Dennis Cranston <dennis_cranston@yahoo.com> Fixes for ui-review bug number 99533. * gnome-data/gtk-events-2.soundlist.in: s/Action button click/Click on command button, s/Check box toggled/Select check box, s/Menu item activation/Choose menu item. * gnome-data/gnome-2.soundlist.in: s/GNOME system events/System events, s/Error Messages/Error message, s/Informational Messages/Informational message, s/Login/Log in, s/Logout/Log out, s/Miscellaneous Messages/Miscellaneous message, s/Question Dialogs/Question dialog, s/Warning Messages/Warning message. The patch for gnome-panel addresses this issue... 2002-12-14 Dennis Cranston <dennis_cranston@yahoo.com> * mailcheck.soundlist.in: s/New Mail/New mail. Fix for ui-review bug number 99533.
*** Bug 103594 has been marked as a duplicate of this bug. ***
Glancing at these patches, there is still no obvious way to remove a sound from an event
Removing sounds from events is bug 14272, so it doesn't need to be fixed to close this bug.
Well, it has been over three months and I haven't seen a response from the gnome-control-center maintainer. If I don't hear any objections soon, I will commit the patch to CVS HEAD and close this bug report.
Um.... I think "People shouldn't commit to CVS without the maintainer's approval" is a good thing to say at this point. Poke the maintainers. Don't threaten to commit things to CVS without waiting for a green light.
Don't call my bluff so soon! I am poking the maintainers. ;-)
Upping pri.
This really needs to go in this time.
Time is running out for ui changes. There's a freeze soon. I hope these patches won't be ignored.
Someone gives me the go ahead, and I will apply the patches.
By the power vested in my be virtue of having made releases of gnome-cc I say 'commit'
I have applied the fixes to CVS HEAD!