After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 99273 - GEdit has GTK_WRAP_CHAR as default print mode [ugh]
GEdit has GTK_WRAP_CHAR as default print mode [ugh]
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.0.5
Other other
: Normal minor
: ---
Assigned To: Gedit maintainers
gedit QA volunteers
: 101015 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-11-22 14:47 UTC by Glynn Foster
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for word-wrap and the Changelog entry (2.96 KB, patch)
2002-12-16 04:49 UTC, Kaushal Kumar 		none Details | Review

Description Glynn Foster 2002-11-22 14:47:27 UTC 
I think default print mode should be GTK_WRAP_WORD [which makes the UI
pretty poopy, since it only has a check box for at wrap at character boundary].
Comment 1 Luis Villa 2002-11-22 15:05:15 UTC 
Would be nice.
Comment 2 Andrew Sobala 2002-11-22 16:33:51 UTC 
See also bug 82710 for implementing preferences. These bugs are not
mutually exclusive.
Comment 3 Paolo Maggi 2002-11-22 18:16:14 UTC 
Note that since libgnomeprint/ui does not use Pango for text layout,
the layout is made by hand 
This is the reason gedit uses a GTK_WRAP_CHAR like wrapping mode, i.e.
when I implemented it, I was too lazy to implement a more advanced
wrapping mode.

BTW, I don't want to modify the print code until libgnomeprint/ui will
be stabilized.

But, patches are wellcome :-)
Comment 4 Kaushal Kumar 2002-12-12 12:47:45 UTC 
Sorry Paolo, did not see this one. I will mark bug #101015 as the
duplicate of this. Kindly review the patch I have put up there.
Comment 5 Kaushal Kumar 2002-12-12 12:48:18 UTC 
*** Bug 101015 has been marked as a duplicate of this bug. ***
Comment 6 Paolo Maggi 2002-12-12 15:49:38 UTC 
Kaushal: you patch seems good (but I have still not tried it).

I'd like to have both wrap mode implemented.

It seems you break lines at spaces. Probably you should also break at
TABS.

Put a ChangeLog entry in the patch.

Thanks.
Comment 7 Kaushal Kumar 2002-12-16 04:46:29 UTC 
I am putting up the patch for the word-wrap (pl. see attachment).
This patch should take care of word-wrapping. 
The existing features of charater wrap and wrap-none are kept
un-altered. For this patch to show any effect, the print preferences
UI must first be enhanced to cater to word-wrap, i.e. a check box for
Word wrap.Bug #82710 should also get resolved through this.
Comment 8 Kaushal Kumar 2002-12-16 04:49:32 UTC 
Created attachment 13017 [details] [review]
Patch for word-wrap and the Changelog entry
Comment 9 Paolo Maggi 2002-12-17 11:30:41 UTC 
Fixed in CVS HEAD