After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 99201 - window list focus line problem
window list focus line problem
Status: RESOLVED DUPLICATE of bug 83393
Product: libwnck
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
AP2
Depends on:
Blocks:
 
 
Reported: 2002-11-21 15:59 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot showing correct thick focus line on panel (4.62 KB, image/png)
2003-04-04 11:53 UTC, bill.haneman
  Details
screenshot showing incorrect thin (interior) focus line on panel (4.67 KB, patch)
2003-04-04 11:54 UTC, bill.haneman
none Details | Review
Patch to fix this issue as stated above. (902 bytes, patch)
2003-07-11 13:40 UTC, Rajkumar
none Details | Review

Description bill.haneman 2002-11-21 15:59:38 UTC
the focus lines don't get thicker according to the theme in many cases;
looks like a clipping rectangle problem.  Possibly related to 99200?
Comment 1 Calum Benson 2003-04-03 13:02:50 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 2 bill.haneman 2003-04-03 13:40:46 UTC
This appears to be fixed...
Comment 3 bill.haneman 2003-04-03 13:42:29 UTC
there's still a problem with the task-switcher/windowlist however,
with regard to focus line thickness; the clipping bounds appear to be
wrong.
Comment 4 bill.haneman 2003-04-03 13:43:22 UTC
Since this is now specific to the window-list I am lowering
status-whiteboard a11y prio.
Comment 5 Mark McLoughlin 2003-04-04 01:01:31 UTC
Bill: please explain the problem further than "the clipping bounds
appear to be wrong". A screenshot may help.
Comment 6 bill.haneman 2003-04-04 11:46:17 UTC
Mark: easier than a screenshot is this test: change to
HighContrastLargePrint theme (you may need to restart your desktop due
to a regression in the theme capplet).  Now focus items on the panel,
you will see a thick focus line.
However if you focus items in the tasklist you will notice that the
focus line appears quite thin; since the line-style is indeed changed
from the default, and the line thickness is not uniform, it appears
that the clipping bounds for drawing components in the task list are
being set without accounting for the increased focus line width.
Comment 7 bill.haneman 2003-04-04 11:53:32 UTC
Created attachment 15467 [details]
screenshot showing correct thick focus line on panel
Comment 8 bill.haneman 2003-04-04 11:54:18 UTC
Created attachment 15468 [details] [review]
screenshot showing incorrect thin (interior) focus line on panel
Comment 9 bill.haneman 2003-04-04 11:55:55 UTC
in the two screenshots, the first focus line thickness is correct, and
the second one is not.  i.e. the panel is correctly drawing the thick
focus line.  linwnck is probably drawing the thick line too, but
either clipping it or overpainting it so that it looks too thin when
focus is interior to the task switcher (rather than exterior to it).
Comment 10 Brian Cameron 2003-07-02 10:17:54 UTC
This a11y stopper bug would be nice to fix before the July 7th
UI freeze deadline.
Comment 11 Rajkumar 2003-07-11 13:39:41 UTC
The focus-line-width is hard coded for tasklist using
gtk_rc_parse_string() in libwnck/libwnck/tasklist.c hence the
LargePrint Theme's couldn't able to override the line width.

I have attached a patch which removes the hard coding, pls. let me
know if am missing something here!
Comment 12 Rajkumar 2003-07-11 13:40:54 UTC
Created attachment 18216 [details] [review]
Patch to fix this issue as stated above.
Comment 13 Havoc Pennington 2003-07-11 18:55:41 UTC
This bug is a duplicate, the other one has some discussion I believe.

Basically you can't break the fact that you get two rows of buttons on
a 48-pixel panel in the process of fixing this.
Comment 14 Rajkumar 2003-07-15 09:59:58 UTC
mmm... didn't realize that it's been already discussed in #83393, am
closing this as duplicate.

*** This bug has been marked as a duplicate of 83393 ***