GNOME Bugzilla – Bug 94019
Prety Menu Icons
Last modified: 2005-02-19 16:20:38 UTC
use the stock Gnome items and add icons in the menus where possible Make Dia pretty! More colours!
mentioned this to Cyrille on IRC i think he agrees it would be good i need to find out how it is done, but Abiword did it recently so i will probably harrass them :)
Do you mean something lke this ? [See <diagram/File> menu for example.] 2002-06-08 Hans Breuer <hans@breuer.org> * app/menus.c : convert from gtk_item_factory_<dump|parse>_rc to gtk_accel_map_<save|load>. Also added common stock-icons to the menu. Since stock icons are done by Gtk nowadays maybe we simply should get rid of GNOME specific menus ?
sounds good to me but i'm no expert. Certainly seems like it would be way easier to maintain. (i had to be very careful to change the keybindings in both places). even though gtk and gnome are the same nowadays, do we risk having to add Gnome menus back in later if they diverge again? I need to figure out what stock icons are available and try and draw more icons that we might need. (I will need to be very careful about the choice of colors, the Gnome icons in Abiword look awful if you are using low color settings in Windows). Does GTK allow you to replace a CheckBoxMenuItem with a 'buttonized image' (hope you know what i mean).
0.91 is GTK2 and has most of the nice stock icons There is also a stock icon which we dont use yet which is a little star for Help-> * About When that is added consider this bug closed. I will add additional bug reports for any other appropriate stock icons or new icons that i design (such as the icons I have created for Group and Ungroup. bug #105519 )
This is the star icon i was talking about: http://developer.ximian.com/themes/icons/ http://developer.ximian.com/images/art-devel/icons16/stock_about-16.png
Sven pointed out the Gimp stock icons to me http://developer.gimp.org/api/1.3/libgimpwidgets/libgimpwidgets-GimpStock.html Some icons i think we could use: Plugin icon http://developer.gimp.org/api/1.3/libgimpwidgets/libgimpwidgets-GimpStock.html#GIMP-STOCK-PLUGIN-CAPS Select All, Select None. I dont particularly like these two but they are worth considering http://developer.gimp.org/api/1.3/libgimpwidgets/libgimpwidgets-GimpStock.html#GIMP-STOCK-SELECTION-ALL-CAPS
These stock icons are missing from gtk/gtkstock.h as of 2.2.1.

Bugs should not target milestones we have already passed, mass retargetting to version 0.95.
Why not share icons between Inkscape, Gimp and Dia where appropriate? It would give the GNOME graphics / design apps a more consistent look-and-feel.
Dia already *is* using standard icons for a long time. IIRC the About Icon isn't used yet because it would have required a higher Gtk+ version.
Since we're going to a higher version of Gtk with the next release anyway, we should take the opportunity to check the stock icons for any we want included. Alan, could you look into this? I believe we'll be doing at least GTK 2.4, higher if any bugs we trigger requires it.
I'm not even going to start looking into sharing icons with the gimp, that could be quite time consuming (not even looking at GNOME stock either). Looking only at GTK for now and working off this page as a reference: http://developer.gnome.org/doc/API/2.4/gtk/gtk-Stock-Items.html In case it seems incoherent I should warn this report was written completely out of order. I'll largely try and start with the items I'm most confident about changing. In some cases it may be appropriate to go ahead and use not just the stock Icon but the stock Menu Item. Send to Back, Bring forward, etc should use the stock icons (but not menu items) GTK_STOCK_GOTO_TOP GTK_STOCK_GOTO_UP GTK_STOCK_GOTO_DOWN GTK_STOCK_GOTO_BOTTOM (Gnumeric does this, i think they also use the stock menu items but I'd prefer not to as it would make our choice of keybindings look really bizarre) We should probably use GTK_STOCK_PROPERTIES in various places. View Show All should probably use the GTK_STOCK_ZOOM_FIT icon. I do hope the Redraw bugs will be sorted out before 1.0 but in the meantime we may as well use GTK_STOCK_REFRESH, maybe even use the stock menu item. I suppose this could always be permanetly left in the debug builds for good measure. GTK_STOCK_COPY might also be appropriate for Duplicate (the GIMP does use similar but subtley different icons for these). I'd be tempted to use the GTK_STOCK_EXECUTE cog icon for Plugins. GTK_STOCK_CONVERT might be appropriate for Export (think I've seen other applications do this. Not the icon abiword is using though). Abiword reuses the Print Icon for Page Setup. Gnumeric doesn't. Probably best left alone. As Hans has already alluded to the GTK About Icon is clearly marked as since 2.6 (i think there might have been a stock Gnome About icon) and if were to make the leap to 2.6 it would be great to go ahead and use the GTK Stock About Dialog. I notice that the Group Properties dialog uses "Ok" instead of the stock OK button. If someone knows the right incantation it might be worthwhile to grep through the source for any other "Ok" buttons. I had a patch attached to another bug report which incidentally fixed the Layers dialog to use stock Icons but I think there might have been something wrong with it. I think my patch to add keybindings for Cut,Copy,Paste Text might have also added stock icons but I'm not sure (and I dont think it was applied either cause I absent mindedly put C comments in by mistake). The Python console doesn't use the stock gtk close button either. From what I can tell the Python console is a copy of the one included in PyGTK. I forget if I patched this upsteam in Pygtk when I was patching other bits of the pygtk demos to use stock icons.
Adding patch keyword to remind us that there's direct instructions for fixes here. Using Copy icon for Duplicate sounds like a bad idea, since we already have Copy. The Print icon should not go on Page Setup, only on Print. The rest sounds good. If you fix it yourself, please remember to update this bug report, otherwise I'll come back to it before 0.95.
Created attachment 37476 [details] [review] patch to add more menu icons sorry but the best I can manage at the moment is patch against 0.94 what I'll try and do next is a bigger patch incorporating the changes i suggested in bug 148174 http://bugzilla.gnome.org/attachment.cgi?id=29790&action=view and when I'm sure the patch compiles correctly I'll try making a patch against CVS (and mabye adjust it so that it will apply cleanly even if I cannot get CVS to compile right now).
Created attachment 37479 [details] [review] patch to add more keybindings and stock menu items This patch was tested thoroughly against Dia 0.94 then adjusted and remade so that it would apply cleanly against CVS from 20050214 about 3 minutes ago. It only took me a ridiculous amount of time to eventually get this right so please do apply the patch before CVS drifts and it no longer cleanly applies. This patch adds various keybindings and menu tweaks in addition to the keybindings. It does NOT change the "Objects" menu to just "Object", I'll do that some other time when my head doesn't hurt from hunger.
Adding PATCH keyword (if Lars added it then someone else removed it) This patch will also close bug 148174 (and it is mostly the same patch, except for the aforementioned Objects/Object and instead of using Ctrl+R for Rulers I've used Ctrl+Shift+R same as the GIMP in case we later want Ctrl+R for Rotate.
I don't think changing Objects to Object makes sense. All but Properties work on several objects as well, some even only work on multiple objects, and Properties will be multi-object too eventually. Other than that the patch is fine and applied. Thanks!