GNOME Bugzilla – Bug 92288
Changes to the panel context menu
Last modified: 2004-12-22 21:47:04 UTC
This patch does two things: Changes the "Delete This Panel" menu item to use the Delete stock icon instead of Remove. This is for two reasons: * consistency with the button in the dialog after it is selected * the Remove stock icon is the opposite of Add, which is used in "Add to Panel" menu, and "Delete this Panel" isn't the opposite of "Add to Panel". I could see an argument for using Close. Moves "Delete this Panel" after "Create Panel", because it just seems like it fits better there (create/delete being so closely related). Mark pointed out that the intended order was "operates on local panel" vs "operates globally", and this kinda makes sense, although one could argue that Deleting a panel is as global as creating one. Anyway, I'll leave that choice to the experts.
Created attachment 10842 [details] [review] context menu changes
dave two comments: 1. I agree using gtk delete icon is probably better. 2. I believe the current layout was the result of the ui review.
Adding PATCH keyword.
The current order was indeed the result of the ui-review, but I'm pretty ambivalent about moving Delete further down the menu if people prefer it. I guess Properties probably is a more common operation, so it probably makes some sort of sense for Properties to be higher up than Delete-- not sure if it should slip all the way down below New Panel, though.
Um, it also depends where your mouse if coming from. ie. if I click on the bottom panel, my mouse pointer will be closer to properties than if I had clicked on the top panel.
Heh, very true... I think we'd cause rather more problems by ordering the menus back to front for panels docked along the bottom of the screen though :)
So what's the conclusion here ? And how does it relate to the ui-review recently done ?
Conclusion: I don't recall (or see) any relevant bugs filed against the top level panel menu arising from the 2.2 ui-review, so I'd be inclined just to leave it the way it is :)
I'd like to change the icon of the "Delete This Panel" to the Delete stock icon and close the bug. Does it sound good ?
Fine by me, anyway...
sounds good to me too
Fixed by: 2003-10-14 Vincent Untz <vincent@vuntz.net> * menu.c: (make_panel_submenu): use GTK_STOCK_DELETE instead of GTK_STOCK_REMOVE for "Delete This Panel" item. Fix bug #92288.