After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 91250 - Unnecessary calls to gtk_widget_child_focus() when menu is displayed
Unnecessary calls to gtk_widget_child_focus() when menu is displayed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.0.x
Other Solaris
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2002-08-20 11:36 UTC by padraig.obriain
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.39 KB, patch)
2002-08-20 11:36 UTC, padraig.obriain 		none Details | Review

Description padraig.obriain 2002-08-20 11:36:04 UTC 
When a menu is shown, calls to gtk_widget_child_focus() are made for each
menu item in an attempt to focus a child of the window containing the
GtkMenu.

This is pointless as a menu item does not focus.
Comment 1 padraig.obriain 2002-08-20 11:36:40 UTC 
Created attachment 10598 [details] [review]
Proposed patch
Comment 2 Owen Taylor 2002-09-24 10:21:39 UTC 
What's the harm of the extra calls? Is it really a
measurable performance issue? 

(Trying to avoid adding code as much as possible, since code
bloat is the ultimate performance and maintainability killer,
though certainly this is a small patch.)
Comment 3 padraig.obriain 2002-09-24 10:28:13 UTC 
I do not have a measure of the improvement.

I felt that avoiding the pointless emission of a signal for every menu
item in the menu was worth the effort.
Comment 4 Owen Taylor 2002-09-25 14:45:41 UTC 
Go ahead and apply the patch to HEAD - I'm not entirely convinced
that it is useful, but it won't hurt.
Comment 5 padraig.obriain 2002-10-01 10:00:54 UTC 
Patch applied to HEAD.