GNOME Bugzilla – Bug 90313
Paper preview not using theme
Last modified: 2004-12-22 21:47:04 UTC
1. The 'Print preview' dialog is not theme compliant. The background/foreground and the font of the display do not change when HighContrastLargePrint, HighContrastLargePrintInverse, LowContrastLargePrint themes are used. 2. In the 'Print' dialog, under 'Paper' option, the preview of the paper is not theme compliant.
What doe sit mean that "the preview of the paper is not theme compliant" ? What behavious would you expect?
The background/foreground color of the preview does not change when HighContrast, HighContrastLargePrint, HighContrastLargePrintInverse, LowContrastLargePrint themes are used. The expected behaviour would be that the color of the preview changes according to the specified theme.
I am not sure about this change. The preview will show whatever color the Application is rendering. What if the image is already high contrast? This is not a widget with white background which contains black ink. It is a canvas, which can contain any color that the app specifies. I agree about the preview of the paper part 2. but not 1..
I don't understand what would be expected fo rthe paper preview: it doesn't contain any text so LargePrint, LargePrintInverse, ... seems meanig less. And about HighContrast: how much more of a contrast would you like?
I just spoke to Bill about this and we reckoned that probably the most useful thing you could do would be to offer the user the option of a monochrome print preview, using the colours of a GtkTextView (say) in the current theme to render the ink and paper. Nothing special need be done for LargePrint themes as you can zoom into the preview anyway.
I think in case of 'Print Preview' option, since there's a zoom option, nothing needs to be done for LargePrint. But in case of 'Print' dialog under 'Paper' option, shouldn't the preview of the paper be a larger one for LargePrint theme?
The 'paper' preview gets bigger if you grab the corner of the dialog and resize it, so this probably isn't a major problem. Yes, it would be nicer if it somehow 'knew' you were using a LargePrint theme and drew it bigger to start with, but I don't think we have a good general solution to that problem at the moment.
With respect to the 'paper' preview, it's not a "high contrast" issue, it's an issue of matching contrast/colors to the current theme (some users will need low contrast, or white-on-black, etc.). So the colors used to render the canvas need to come from the theme, or at least pay some attention to the theme.
I have fixed the second issue mentioned in this bug. I have removed the hardcoding and used the following theme colors: PAGE_COLOR = base[GTK_STATE_NORMAL] BORDER_COLOR = text[GTK_STATE_NORMAL] SHADOW_COLOR = bg[GTK_STATE_ACTIVE] ARROW_COLOR = base[GTK_STATE_SELECTED] PMARGIN_COLOR = base[GTK_STATE_SELECTED] LMARGIN_COLOR = bg[GTK_STATE_SELECTED] LMARGIN_COLOR_HL = bg[GTK_STATE_SELECTED] STRIPE_COLOR = text[GTK_STATE_NORMAL] STRIPE_COLOR refers to the contents shown as bar and a rectangle inside the preview. I guess we need a discussion on the first issue, hence i have opened a new Bug 96802
Created attachment 11829 [details] [review] patch created with "gnome-2-0" branch source
Just to confirm this patch works well with all the themes I've tried... would be great if we could get it back into HEAD, nudge nudge :)
The patch looks good from a quick glance over. I'll get to it next week. thanks, Chema
Guys, this should have been filed as two different bugs. The issues here are totally different. I'm making this bug the paper preview issue, since it has a patch already.
Created attachment 12833 [details] [review] cvs commit
Fixed in CVS.
Chema: Is it Ok to commit the patch (id = 11829) to gnome-2-0 branch ?
Yes, go ahead.