GNOME Bugzilla – Bug 86631
GWeather applet doesnÃ,´t work at all
Last modified: 2004-12-22 21:47:04 UTC
Package: gnome-applets Severity: critical Version: 2.00 Synopsis: GWeather applet doesn´t work at all Bugzilla-Product: gnome-applets Bugzilla-Component: gweather Description: Description of Problem: It says 'Retrieval failed'. Previous version (with Gnome 1.4) worked fine though. None of the locations works, and I don´t have a proxy server or something like that. Other internet related applications are working fine. Steps to reproduce the problem: 1. Add the weather report applet to a panel Actual Results: ´Retrieval failed' (? -) Expected Results: A nice icon showing the current weather. How often does this happen? Always Additional Information: ------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-06-27 13:35 ------- Reassigning to the default owner of the component, gnome-applets-maint@bugzilla.gnome.org.
Confirming
Hrm. Works just fine here. Sure there is no proxy? And you've configured the location correctly? Andrew: it is really helpful if you add the GNOME2 keyword to unconfirmed bugs that relate to GNOME2 when you find them. Makes it much easier for me to find them and adjust accordingly.
Luis: I know, just forgot on this one. Anyway, reproducing sequence: 1. Add applet ;-) 2. Preferences -> Select location -> Europe -> United Kingdom -> Leeds and Bradford 4. Update applet a lot It _sometimes_ doesn't work, but after the first failure it keeps failing.
Okay, I just committed a changed to cvs that may fix this. If someone could test this, that would be great. Andrew: Many, Many thanks for providing repeatable steps to reproduce this :) Here's the relavant ChangeLog entry: 2002-07-01 Kevin Vandersloot <kfv101@psu.edu> * weather.c: set gweather_applet->gweather_info to the newly created info structure. Hopefully fixes bug #86631 and maybe some others. Prevents multiple http requests when the location has been changed and updated
okay, on a similar note here, I had this but with another procedure: A) add applet B) select Europe- > sweden -> norrköping C) go to prefrences, set metric units D) Close - retrieval will fail, when opening the location again it will be unselected. it works if one doubleclicks the location and then closes. -- Since I'm unable to use CVS I can't help you with further information here. System: Gentoo, gcc 3.1 -O2 -march=athlon-tbird + debugging , No proxy. NAT
Kevin: I'm rebuilding gnome from CVS tonight, and I'll test this later.
Still broken with my both my steps and spider's steps to reproduce :-(
yah, and I need to revert the change since it leads to even more breakage :( Really a lot of the code needs rewriting.
Created attachment 9634 [details] [review] Proposed patch
does the above patch fixes the problem andrew?
Fixed for me
Woops, reopened since this isn't in CVS yet :-)
kfv101@psu.edu pointed out that this bug is related to bug 79787. I tend to agree. Perhaps that means that the patch posted above will fix that bug?
Ben: can you try out the patch also?
Deepa: I don't think the applet should update when the section changes in the prefs dialog. That means that keyboard users will get an update every time they navigate with the arrow buttons. Otherwise I'm going to test the patch locally for a bit, before I commit.
Okay, I just commited to cvs a fix based on Deepas patch. If you guys could test this, that would be great. I'm going to leave this open for now.
Definitely fixed.