After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 85966 - renaming desktop icons only works after restart if fam is not installed
renaming desktop icons only works after restart if fam is not installed
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
unspecified
Other Linux
: High major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-06-19 18:25 UTC by lago
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Possible fix. (674 bytes, patch)
2002-07-01 17:46 UTC, Damon Chaplin
none Details | Review

Description lago 2002-06-19 18:25:33 UTC
If I rename an icon on my desktop (be it one of the "standard" icons or a
custo icon), the old name stays until nautilus is restarted (read: gnome is
restarted). It really looks as if the icon hasn't been renamed at all,
which is confusing. This is nautilus 2.0.0 as in debian experimental (I
believe this is gnome2 RC1).
Comment 1 Dave Bordoley [Not Reading Bug Mail] 2002-06-19 18:41:00 UTC
are you using fam? can you try using ctrl+R (reload shortcut) from the
desktop
Comment 2 lago 2002-06-19 19:33:37 UTC
I don't know what "fam" is, but CTRL-R works. This is not very
"user-friendly", though; IMHO it's still a bug.
Comment 3 Dave Bordoley [Not Reading Bug Mail] 2002-06-19 20:59:05 UTC
oh no i'm not claiming this as a solution, just trying to help figure
out whats going on :) What distro are you using. If you are using
redhat (or any other rpm based distro) can you try "rpm -q fam". Thanks
Comment 4 lago 2002-06-19 23:21:10 UTC
Well, I installed fam (I'm using debian, but it too has a package for
fam) and it solved the problem; however, this seems a lot like a hack
to me; If I use nautilus to rename the file, why should it be notified
of the change by a daemon? Well, maybe there's a good reason :-)
Comment 5 Dave Bordoley [Not Reading Bug Mail] 2002-06-20 01:02:15 UTC
You may be right that nautilus shouldn't depend on fam to refresh the
desktop icons, also i'm not trying to pose this as a solution to your
specific problem. I was just trying to figure out what was going on so
that the developers can diagnose the problem and figure out what needs
to be fixed.
Comment 6 Dave Bordoley [Not Reading Bug Mail] 2002-06-20 12:12:10 UTC
btw, did this bug only occur on your desktop or did it also occur in
the icon and list views as well. Can you please test this if you
haven't  already? thanks ...
Comment 7 Carsten Menke 2002-06-20 15:38:14 UTC
Ok, I compiled yesterday using the cvsgnome script 0.20 grabbing the
latest tarballs. 

I remark the same behavior, I'm using LFS-3.0 with gcc-2.95.3 and
glibc.2.2.5, I could resize the Icon change the Icon but the renaming
of an Desktop Icon only takes place after a gnome restart. I think
this should not make it into 2.0, really.

Will reboot now, to LFS and try the CTRL-R method.
Comment 8 Carsten Menke 2002-06-20 17:21:59 UTC
This is from Gnome2 using Opera :-)

I found out that this is only related to Launchers. If I add a 
new Folder to the Desktop then I could rename it without 
restarting.

Also CTRL-R works me as well. To reproduce do the following:

Right-Click on Desktop
-> New Launcher

Add something into the Fields (TEST,TEST,TEST for example)

Choose an Icon (or choose none)

Try to rename the newly created Launcher.

For all other Types I tested so far it works, without hitting 
CTRL-R or restarting Gnome2
Comment 9 Luis Villa 2002-06-21 00:09:57 UTC
ah-ha! Thanks for the research, bootsy. This is very borderline
high... but it is one of those /very/ visible and possibly frustrating
bugs so I'm marking it that way.
Comment 10 Carsten Menke 2002-06-23 14:45:49 UTC
It goes further, when you create a Link on the Desktop I see this 
behavior as well. Still it doesn't happen if you create a New 
Folder. So I think this should now easy to fix, see what routines 
are called when a creating a new Folder (renaming a Folder) and see 
if they are missing for New Launcher, New Link etc. etc.
Comment 11 Damon Chaplin 2002-07-01 17:46:59 UTC
Created attachment 9555 [details] [review]
Possible fix.
Comment 12 Damon Chaplin 2002-07-01 17:49:39 UTC
The .desktop file was being updated fine, and was emitting the "changed"
signal. However it still assumed the old file info was OK so used the
old display name.

The patch invalidates the display name, and seems to work.
Though I don't know how nautilus_file_invalidate_attributes() is
supposed to be used so I'm only guessing.
Comment 13 Damon Chaplin 2002-07-02 20:41:36 UTC
patch applied. Reopen if you still see it.