After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84774 - Sounds for events are not playing
Sounds for events are not playing
Status: VERIFIED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other Solaris
: High major
: ---
Assigned To: jacob berkman
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-06-10 18:29 UTC by Shane O'Connor
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix login/logout files (558 bytes, patch)
2002-06-12 21:07 UTC, jacob berkman
none Details | Review
patch to make login / logout sounds, and to load login sound before g-s-d starts (7.66 KB, patch)
2002-06-12 21:08 UTC, jacob berkman
none Details | Review
from looking at gnomeui code this patch is more correct (7.93 KB, patch)
2002-06-12 21:31 UTC, jacob berkman
none Details | Review

Description Shane O'Connor 2002-06-10 18:29:44 UTC
testing ultra 10 with solaris 8 and sun's prebeta1_build3 (built from 8th
of june)

sound events are no being played.

to recreate
----------
1) using the sound capplet enable the sound for events option and the sound
on startup option.
2) logout and login  => no login sound played
3) start sound capplet and display 'Sounds for Events' tab
4) select a sound and click 'Play' - sound is played.
5) logout => not sound played for logout
Comment 1 Luis Villa 2002-06-11 14:44:54 UTC
Jody, can you take a look at this?
Comment 2 jacob berkman 2002-06-11 21:15:40 UTC
looks like gnome-session doesn't do the sound calls.
Comment 3 Damon Chaplin 2002-06-12 19:52:39 UTC
I'm surprised it could play sounds on your Ultra 10.
It doesn't on mine. See bug #84172. Any ideas on that, Shane?
Comment 4 jacob berkman 2002-06-12 21:07:47 UTC
Created attachment 9181 [details] [review]
patch to fix login/logout files
Comment 5 jacob berkman 2002-06-12 21:08:23 UTC
Created attachment 9182 [details] [review]
patch to make login / logout sounds, and to load login sound before g-s-d starts
Comment 6 jacob berkman 2002-06-12 21:11:20 UTC
this bug had a few parts:

1.  the sound list specified a non-existent file
2.  nothing was doing the calls to make the sounds
3.  gnome-session would make the sound before gnome-settings-daemon
had started esd/loaded the sample

this patch also fixes up the halt/reboot configure.in checks.

anders, mark, ok to commit?
Comment 7 jacob berkman 2002-06-12 21:31:40 UTC
Created attachment 9183 [details] [review]
from looking at gnomeui code this patch is more correct
Comment 8 Shane O'Connor 2002-06-13 11:31:01 UTC
will test on next available build.
Comment 9 Shane O'Connor 2002-06-13 15:26:53 UTC
some additional information for sparc users...

for sound events to play via speakers on the sparc, in sdtaudiocontrol
you have to enable the "Internal cd" option on the 'Record' tab and
raise the volume for 'Monitor' (then logout and log back in again).
Comment 10 jacob berkman 2002-06-13 16:09:12 UTC
btw shane - this isn't committed yet, and mark doesn't want me to
commit it until after he makes a gnome 2.0.0 tarball (some time next week)
Comment 11 Shane O'Connor 2002-06-13 16:19:32 UTC
np jacob - just give me a shout when done - cheers
Comment 12 jacob berkman 2002-06-19 20:29:25 UTC
fixed in CVS:

2002-06-19  jacob berkman  <jacob@ximian.com>

        * main.c (main): call the gsd and sound functions

        * gsm-sound.[ch] (gsm_sound_login): if built with esound support,
        start esd and load the login sound, and play the login sound
        (gsm_sound_logout): play the logout sound
        
        fixes bug #84774
Comment 13 Shane O'Connor 2002-06-26 15:25:14 UTC
just tested this on a cvs build from yesterday - are there sun patches
that need to be added for sounds?

there is no sounds playing at all now - not even when you hit the play
button in the Sound capplet.

Comment 14 jacob berkman 2002-06-26 17:31:07 UTC
did you test with a sun build?

the fix went in after the branch i believe, and there weren't patches
placed in sun-patches.
Comment 15 Shane O'Connor 2002-06-26 17:34:38 UTC
tested with a build from wipro taken from CVS 25th june (yesterday) -
you'd have to check with them about what patches etc went in...:)
Comment 16 jacob berkman 2002-07-01 16:34:48 UTC
i had forgotten to commit the other half:

2002-07-01  jacob berkman  <jacob@ximian.com>

        * gnome-data/gnome-2.soundlist.in: use login/logout files that
        actually exist (bug #84774)
Comment 17 Shane O'Connor 2002-07-15 14:19:08 UTC
sounds verified fixed - tested in nightly built from CVS on 14th july

Comment 18 Shane O'Connor 2002-07-15 14:25:26 UTC
closing