After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 82780 - Thumbnails are flat
Thumbnails are flat
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Thumbnails
0.x.x [obsolete]
Other Linux
: High minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-05-23 18:36 UTC by Tuomas Kuosmanen
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
simple fix (604 bytes, patch)
2002-06-21 20:20 UTC, Damon Chaplin
none Details | Review

Description Tuomas Kuosmanen 2002-05-23 18:36:53 UTC
Thumbnails dont seem to use the thumbnail frame image that made the nice
drop shadow thing around the photo.

This has been the case for at least a week on CVS HEAD, a lot of other
people seem to report the same thing on IRC.

Also as a side issue, should themes be able to supply their own thumbnail
frame? There is stuff about that on the theme XML file, and the sample
themes used to ship their own thumbnail frame png file, but I never got
that to work on the themes I did. So I am puzzled a bit..
Comment 1 Luis Villa 2002-06-10 11:22:04 UTC
Eck... 
Comment 2 Tuomas Kuosmanen 2002-06-21 07:00:41 UTC
Anyone have a clue about this? It is pretty bad since it makes the
thumbnails a lot less polished looking, thus making some of the nice
looking stuff of nautilus just not show at all :-/

Does this work for anyone using the gnome2 version?
Comment 3 Luis Villa 2002-06-21 11:27:45 UTC
This is slightly abusive but marking high. No, still doesn't work here.
Comment 4 Dave Bordoley [Not Reading Bug Mail] 2002-06-21 12:56:08 UTC
Since tigert asked. Seems broken for me too.
Comment 5 Damon Chaplin 2002-06-21 19:20:57 UTC
I'll have a look at this.

It does use nautilus_theme_get_image_path ("thumbnail_frame.png")
to get the frame, so I think it should be themeable.

It even seems to have properties for offsets:
 frame_offset_str = nautilus_theme_get_theme_data ("thumbnails", 
                 "FRAME_OFFSETS");
Comment 6 Damon Chaplin 2002-06-21 20:20:41 UTC
Created attachment 9383 [details] [review]
simple fix
Comment 7 Damon Chaplin 2002-06-21 20:23:13 UTC
The problem was just an incorrect path.

However, small images (<16K or something similar) are used as-is,
and so won't be in the thumbnails directory. So they won't have the
border added. I don't know nautilus 1.4 was like that.
Comment 8 Damon Chaplin 2002-06-21 20:31:43 UTC
Using different borders in themes seems to work.
I copied the border, made it red, and put it in the tahoe pixmaps
directory and it was used instead of the default.
Comment 9 Damon Chaplin 2002-06-25 18:25:10 UTC
Patch applied.
Comment 10 Tuomas Kuosmanen 2002-06-26 23:36:14 UTC
fix0rage confirmed. Yay and thanks!