GNOME Bugzilla – Bug 82586
Panel has inconsistant strings, lack of mnemonics
Last modified: 2015-03-24 13:00:35 UTC
As detailed in http://www.maths.tcd.ie/~gfoster/ui-review/ui-review-panel.txt it has inconsistant strings, lack of mnemonics etc... Attaching patch to fix this. I'll try and keep this patch uptodate - it can't be commit until after the ui freeze. The panel-config.c changes need a lot of work still.
Created attachment 8654 [details] [review] usability and string changes
Adding fields
Oh yeah, we should also - a) remove corner panel b) have an option in the panel properties for the sliding panel to snap to corners c) remove all the property position stuff and have a panel 'move' mode on the context menus Adding usability people for discussion...definitely not 2.0 though so start fixing other bugs ;)
Created attachment 8675 [details] [review] string changes only - minus panel-config.c
Okay, so here's the patch with all the string changes [except for panel-config.c because that's not totally figured out yet]. Calum, Seth, Nils - can you look at this so that others don't assume I'm on crack?
I'll certify that you're on crack. Nonetheless the patch looks good :-)
Removed accessibility keyword. Patch will be committed post 2.0
Looks about right... John S. won't be pleased, though, he wanted all the #ui-review changes in for 2.0.0 :)
Ach, don't be worried about him. Sun will have plenty of time to get these changes in. We can even patch them locally for now knowing that they'll get merged for 2.0.1 or 2.0.2...no big deal i don't think.
I've committed the string changes. Thanks.