After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 81791 - make DESTDIR=/pkgdir install - doesn't work correctly
make DESTDIR=/pkgdir install - doesn't work correctly
Status: VERIFIED FIXED
Product: gimp-perl
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GIMP Bugs
Daniel Egger
Depends on:
Blocks:
 
 
Reported: 2002-05-14 20:56 UTC by max
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description max 2002-05-14 20:56:07 UTC
hola,

i tried to create a package using:
make DESTDIR=/pkgdir install
This is supposed to copy the files to /pkgdir/"prefix" instead of
/"prefix". It works for most of the files, but at the end (I think where
it's trying to install some plugins) it ignores the DESTDIR and trys to
install to the real destination instead.. which of course is bad because
these files will be missing in the package.

Max
Comment 1 Raphaël Quinet 2002-05-15 07:11:55 UTC
Could you be a bit more specific about what happens "at the end"?
It would be easier to check and fix this bug if you could point out
when this occurs (in which directory/Makefile) and maybe what files
are affected.
Comment 2 max 2002-05-15 20:08:59 UTC
hello,

i have removed gimp again and then recompiled / reinstalled to find
the error.

it's in .../gimp-1.2.3/plug-ins/perl/Makefile, at the line that reads:

for plugin in * ; do \
  /usr/bin/ginstall -c "$$plugin" $(gimpplugindir)/plug-ins/ ; \
done

that should be changed to the following:

for plugin in * ; do \
  /usr/bin/ginstall -c "$$plugin" $(DESTDIR)$(gimpplugindir)/plug-ins/ ; \
done
that seems to be enough to get it through the install process while
using DESTDIR=

though I have noticed another thing.. just a warning:

libtool: install: warning: `../../libgimp/libgimpui.la' has not been
installed in `/usr/local/lib'
libtool: install: warning: `../../libgimp/libgimp.la' has not been
installed in `/usr/local/lib'
i get this warning a few dozen times. you think i can ignore that? or
is it something else that needs to be fixed when running the
installation with DESTDIR=?

cya
Comment 3 Sven Neumann 2002-05-16 10:27:46 UTC
I'd appreciate if Yosh would have a look at this.
Comment 4 Manish Singh 2002-06-16 20:50:46 UTC
Are you sure the perl examples are the only things not following
$DESTDIR? AFAIK, the perl makefile stuff itself (which the perl
installed on the users system generates) doesn't follow that either,
so Gimp.pm etc. won't be installed within the $DESTDIR either. A quick
search on the net reveals several other packages haven't solved this
problem either.

So $DESTDIR isn't supported with --enable-perl until perl is fixed
itself. Packagers always seem to special case this.
Comment 5 Sven Neumann 2002-07-09 15:47:04 UTC
Looks as if we can not do anything about this until someone finds a
way to better integrate the build of gimp-perl with the rest of the
GIMP build.
Comment 6 Sven Neumann 2003-03-01 16:22:49 UTC
Fixed by Marc Lehmann:
        - use DESTDIR when installing plug-ins.
Comment 7 Raphaël Quinet 2003-06-20 18:50:08 UTC
The fix is part of the stable release 1.2.4.  Closing this bug.
Comment 8 Dave Neary 2004-01-05 19:42:40 UTC
Changing a bunch of bugs I missed (no idea why) to the gimp-perl product