GNOME Bugzilla – Bug 80977
Pager-applet displays row where cols is right.
Last modified: 2004-12-22 21:47:04 UTC
In the Preferences dialog of the Pager applet. The user can choose how many rows the pager should have. But this is only true for horitontal orientation. For vertical Orientation the stetting actually changed how many columns the pager has. How to reproduce: Put the Pager on any vertical panel. change the "rows" in the preferences. Expected: the layout and the text correspond. Actual: rows and columns are exchanged. Rationale for patch. I think it is reasonable to let the user specify how to devide the space that corresponds to the panel size. (You coould argue about that). And this is easy to fix this way. But the situation without the patch is a bit confusing for the user. This patch just changes the wrong "Rows" into "cols" if the applet is vertical. I think this may have an inpact to docs and strings. (Or maybe my patch is just on crack, and i should make two glade templates...) The atk stuff is totally unchanged, so the ATK name will be wrong in the vertical case(I don't know about this stuff, and don't like to fiddle with things i don't understand) Also as I'm not an native speaker of english I could not think of any reasonable change for the short description in the schema, the long description isn't much better. Anyhow better write a patch to get rolling than just bitching at the mailinglist ;-)
Created attachment 8242 [details] [review] The intial patch
Marking high due to the patch. Incidentally, I'm not entirely sure this needs the a11y keyword.
I think it has to be "Columns" instead of "Cols".
Just changed "Cols" to "Columns". I'm still uncertain of the atk stuff(as i don't know how it is used how it should be etc).
Created attachment 8290 [details] [review] new patch
Applied.