GNOME Bugzilla – Bug 797290
qtmux: Allow up to 1% of frame rate for lateness
Last modified: 2018-10-22 11:36:49 UTC
See commit message
Created attachment 373941 [details] [review] qtmux: Allow up to 1% of frame rate for lateness
Comment on attachment 373941 [details] [review] qtmux: Allow up to 1% of frame rate for lateness Needs some further explanation *why* this is a good idea, in the commit message and as a comment. What is this preventing?
Created attachment 373943 [details] [review] qtmux: Allow up to 1% of frame rate for lateness
Created attachment 373944 [details] [review] qtmux: Allow up to 1% of frame rate for lateness
Review of attachment 373944 [details] [review]: commit 09904e59df1223da8e028ea1e5b4a135ddd82a98 (HEAD -> master, origin/master, origin/HEAD) Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Tue Oct 2 19:32:47 2018 +0300 qtmux: Allow up to 1% of frame rate for lateness https://bugzilla.gnome.org/show_bug.cgi?id=797290
I'm not very happy to see that no further explanation was given in the commit message.
Same here. And I don't think this should be the default behaviour. reopening and marking as blocker.
The explanation is in the commit itself in a comment and was forgotten to be copied over to the commit message. In summary, this is necessary to create files that are compatible with "professional" software like Premiere and Final Cut, that simply don't work well at all with edit lists. And Nicolas also mentioned that various other software does not support (or does not support well) edit lists, so we should by default try to not write edit lists if we can somehow prevent it.
I understand the requirement. My point is that the muxer now "automagically" modifies the incoming DTS/PTS, whereas this is something that should maybe be made explicit.
It changes the timestamps by up to 0.4ms for a 25fps stream, less for higher framerates. You're thinking of having a property for this to set a threshold?
As discussed on IRC, a tolerance/threshold property will be added.
Created attachment 373972 [details] [review] qtmux: Add property for providing a threshold after which we create an edit list for gaps at the start
Attachment 373972 [details] pushed as 01a2119 - qtmux: Add property for providing a threshold after which we create an edit list for gaps at the start