GNOME Bugzilla – Bug 797272
rtspconnection: do not duplicate authentication headers
Last modified: 2018-10-18 13:22:59 UTC
See commit message
Created attachment 373890 [details] [review] rtspconnection: do not duplicate authentication headers rtsp_connection_send takes care of adding those already, and some reverse proxies such as nginx will reject the request altogether if the Authorization header is present twice, even with the same value.
Review of attachment 373890 [details] [review]: There's send for the connection and for the watch. Are both always adding the auth header? If yes, good to go
(In reply to Sebastian Dröge (slomo) from comment #2) > Review of attachment 373890 [details] [review] [review]: > > There's send for the connection and for the watch. Are both always adding > the auth header? > > If yes, good to go Yes, both will, in any case the messages here were only sent with rtsp_connection_send :)
Attachment 373890 [details] pushed as aa6daaa - rtspconnection: do not duplicate authentication headers
Also picked into 1.14.