After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797229 - --without-gnome configure switch
--without-gnome configure switch
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: pptp
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-09-30 03:07 UTC by Douglas Kosovic
Modified: 2018-09-30 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
--without-gnome patch (1.03 KB, patch)
2018-09-30 03:07 UTC, Douglas Kosovic 		none Details | Review

Description Douglas Kosovic 2018-09-30 03:07:37 UTC 
Created attachment 373813 [details] [review]
--without-gnome patch

Please find attached a patch which doesn't build the GNOME based properties/ directory if --without-gnome is specified.


With current source, using the --without-gnome configure switch and building without GNOME based package dependencies installed results in the following error :

  CC       shared/nm-utils/properties_libnm_vpn_plugin_pptp_editor_la-nm-shared-utils.lo
In file included from shared/nm-utils/nm-shared-utils.c:22:0:
./shared/nm-default.h:105:10: fatal error: nma-ui-utils.h: No such file or directory
 #include <nma-ui-utils.h>
          ^~~~~~~~~~~~~~~~
Comment 1 Thomas Haller 2018-09-30 11:18:43 UTC 
The patch is not entirely right.

+if WITH_GNOME
 plugin_LTLIBRARIES += properties/libnm-vpn-plugin-pptp.la
+endif

libnm-vpn-plugin-pptp is the core part of the plugin. It has no GTK (Gnome) dependencies. It can always be built as it has no dependencies that wouldn't be satisfied already.


Merged to master with modification: https://gitlab.gnome.org/GNOME/NetworkManager-pptp/commit/28317b93099106b0e73323e99113e56f0e7240c6


Thanks!!