GNOME Bugzilla – Bug 797198
Split out ffmpeg from gst-libav-1.0 to its own recipe
Last modified: 2018-09-26 12:19:55 UTC
I haven't attached the Meson port of gst-libav here because I'm seeing some strange build failures in it.
Created attachment 373747 [details] [review] Split out ffmpeg from gst-libav-1.0 to its own recipe This allows people to more easily replace the recipe with their own ffmpeg, or change the configuration. Also allows us to move gst-libav-1.0 to Meson.
It's also needed for when we drop autotools in gst-libav (eventually).
Review of attachment 373747 [details] [review]: Maybe I'm confused, but iirc the LA generator was moved inside custom Makefile in gst-libav repo. We need to bring it back into cerbero now I guess.
Created attachment 373766 [details] [review] Split out ffmpeg from gst-libav-1.0 to its own recipe This allows people to more easily replace the recipe with their own ffmpeg, or change the configuration. Also allows us to move gst-libav-1.0 to Meson.
(In reply to Nicolas Dufresne (ndufresne) from comment #3) > Review of attachment 373747 [details] [review] [review]: > > Maybe I'm confused, but iirc the LA generator was moved inside custom > Makefile in gst-libav repo. We need to bring it back into cerbero now I > guess. Fixed. Interestingly, the la files that were being generated contained `-llzma` which cerbero didn't provide, so they were wrong. I wonder why no one complained.
Attachment 373766 [details] pushed as 3121278 - Split out ffmpeg from gst-libav-1.0 to its own recipe
Yeah, the BZ/LZMA and many other things are particularly racy. We basically run an check in configure.ac, and hope configure in ffmpeg will get the same answer. But in theory, autotools buidls for Android should not have the ZMA lib unless it's found on the root fs. Thanks for your work !