After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797186 - meson: Specify encoding to UTF-8 when building with MSVC
meson: Specify encoding to UTF-8 when building with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-21 13:44 UTC by Seungha Yang
Modified: 2018-09-21 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[core] meson: Specify encoding to UTF-8 (989 bytes, patch)
2018-09-21 13:47 UTC, Seungha Yang 		committed Details | Review
[base] meson: Specify encoding to UTF-8 (998 bytes, patch)
2018-09-21 13:48 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2018-09-21 13:44:07 UTC 
Fix build on some non-US locale Windows systems
Comment 1 Seungha Yang 2018-09-21 13:47:13 UTC 
Created attachment 373726 [details] [review]
[core]  meson: Specify encoding to UTF-8

Fix build on some non-US locale Windows systems

Error:
  gstreamer/gst/gstdebugutils.c(194): error C2001
Comment 2 Seungha Yang 2018-09-21 13:48:19 UTC 
Created attachment 373727 [details] [review]
[base] meson: Specify encoding to UTF-8

Error:
  gst-plugins-base/tools/gst-device-monitor.c(278): error C2001
Comment 3 Tim-Philipp Müller 2018-09-21 17:43:23 UTC 
Bit surprised that those are the only files, or is it simply the first error and then it stopped?

In any case, thanks for the patches!

commit 54e498f2d57ceeed7a68e274e5c3786b4afdc9c0
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Fri Sep 21 22:26:00 2018 +0900

    meson: Specify encoding to UTF-8 when building with MSVC
    
    Fix build on some non-US locale Windows systems
    
    Error:
      gstreamer/gst/gstdebugutils.c(194): error C2001
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797186


commit cfc8d7ec9e37cf766e787a93af5bb4a6ea5b49fa
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Fri Sep 21 22:31:33 2018 +0900

    meson: Specify encoding to UTF-8 when building with MSVC
    
    Fix build on some non-US locale Windows systems
    
    Error:
      gst-plugins-base/tools/gst-device-monitor.c(278): error C2001
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797186
Comment 4 Seungha Yang 2018-09-21 18:16:43 UTC 
(In reply to Tim-Philipp Müller from comment #3)
> Bit surprised that those are the only files, or is it simply the first error
> and then it stopped?

Not sure whether another file could cause the problem. They are the first error and I didn't try to find more ...