GNOME Bugzilla – Bug 797158
gl: some miscellaneous fixes to gir generation
Last modified: 2018-09-18 09:41:03 UTC
See commit logs. The first patch (include GL-1.0.gir) is experimental, but it seems to me a good idea, but the others are required
Created attachment 373673 [details] [review] gl/gir: include GL-1.0.gir For generating GstGL-1.0.gir it looks required to add GL-1.0.gir from GTK+ gir files repository, to have binding to GL's types
Created attachment 373674 [details] [review] gl: meson: add missing headers for gir generations There are a lot of symbols in GstGL-1.0.gir generated by automake that are not when it is generated by meson, because a lot of headers were not included in meson's gir generation.
Created attachment 373675 [details] [review] gl/egl: fix annotation for gst_egl_image_new_wrapped()
(In reply to Víctor Manuel Jáquez Leal from comment #1) > Created attachment 373673 [details] [review] [review] > gl/gir: include GL-1.0.gir > > For generating GstGL-1.0.gir it looks required to add GL-1.0.gir from > GTK+ gir files repository, to have binding to GL's types Wasn't the idea to simply not generate the GL funcs, so that no GL types are in the API?
(In reply to Sebastian Dröge (slomo) from comment #4) > (In reply to Víctor Manuel Jáquez Leal from comment #1) > > Created attachment 373673 [details] [review] [review] [review] > > gl/gir: include GL-1.0.gir > > > > For generating GstGL-1.0.gir it looks required to add GL-1.0.gir from > > GTK+ gir files repository, to have binding to GL's types > > Wasn't the idea to simply not generate the GL funcs, so that no GL types are > in the API? Yes. Just I experimented a bit. That's why I mentioned that in comment #1. I guess we could ditch that patch. Btw, I just updated my branch for gstreamer-gl-sys with the GLFunc removed :)
Review of attachment 373673 [details] [review]: no need of it :)
Attachment 373674 [details] pushed as e12a55a - gl: meson: add missing headers for gir generations Attachment 373675 [details] pushed as 982b212 - gl/egl: fix annotation for gst_egl_image_new_wrapped()