After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797089 - flvmux: Don't omit streamheader from caps on downstream reconfigure
flvmux: Don't omit streamheader from caps on downstream reconfigure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-06 04:36 UTC by Seungha Yang
Modified: 2018-09-09 06:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flvmux: Don't omit streamheader from caps on downstream reconfigure (5.64 KB, patch)
2018-09-06 04:37 UTC, Seungha Yang 		committed Details | Review
tests: flvmux: Add check consistency of src caps (6.38 KB, patch)
2018-09-09 06:33 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2018-09-06 04:36:43 UTC 
The reconfigured downstream elements (e.g., dynamically added sink element)
most likely require the flv streamheader
Comment 1 Seungha Yang 2018-09-06 04:37:18 UTC 
Created attachment 373552 [details] [review]
flvmux: Don't omit streamheader from caps on downstream reconfigure
Comment 2 Seungha Yang 2018-09-06 04:40:46 UTC 
Initially, I configured pipeline like 
... ! flvmux ! tee name=t ! queue ! rtmpsink

Then, during playing state, t. ! queue ! rtmpsink produced a caps without streamheader
Comment 3 Olivier Crête 2018-09-06 19:53:09 UTC 
The fix is correct, so I merged it. But can you explain a bit more how you trigger the problem, I'd like to see if we can write a simple unit test to prevent regressions.

Attachment 373552 [details] pushed as 1cd5a52 - flvmux: Don't omit streamheader from caps on downstream reconfigure
Comment 4 Seungha Yang 2018-09-09 06:33:00 UTC 
Created attachment 373572 [details] [review]
tests: flvmux: Add check consistency of src caps
Comment 5 Seungha Yang 2018-09-09 06:35:11 UTC 
(In reply to Olivier Crête from comment #3)
> The fix is correct, so I merged it. But can you explain a bit more how you
> trigger the problem, I'd like to see if we can write a simple unit test to
> prevent regressions.

The new unit test code is one example of the issue.