After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797072 - discoverer: Consider closedcaption/ as subtitles and improve subtitle caps detection
discoverer: Consider closedcaption/ as subtitles and improve subtitle caps de...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-04 08:59 UTC by Sebastian Dröge (slomo)
Modified: 2018-09-04 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
discoverer: Consider closedcaption/ as subtitles and improve subtitle caps detection (1.95 KB, patch)
2018-09-04 08:59 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-09-04 08:59:42 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2018-09-04 08:59:49 UTC 
Created attachment 373546 [details] [review]
discoverer: Consider closedcaption/ as subtitles and improve subtitle caps detection

Generally all subtitle/, subpicture/, text/, closedcaption/ and
application/x-subtitle caps instead of hardcoding a small set of caps.
Comment 2 Thibault Saunier 2018-09-04 12:27:39 UTC 
Review of attachment 373546 [details] [review]:

Makes sense but in the end the caps we get might not match the caps template if you use `_has_prefix`, can't that be a problem?
Comment 3 Sebastian Dröge (slomo) 2018-09-04 13:10:46 UTC 
What template caps? I don't understand what you mean :)

For video/audio we also just do a prefix check on audio/ and video/ and image/
Comment 4 Thibault Saunier 2018-09-04 13:21:32 UTC 
Review of attachment 373546 [details] [review]:

You are right, nvm :-)
Comment 5 Sebastian Dröge (slomo) 2018-09-04 13:37:08 UTC 
Thanks, pushed then :)