GNOME Bugzilla – Bug 797037
decklink: Only use drop-frame flag for 29.97 and 59.94 FPS
Last modified: 2018-08-28 13:03:28 UTC
See commit message
Created attachment 373481 [details] [review] decklink: Only use drop-frame flag for 29.97 and 59.94 FPS Otherwise it can cause errors in gstvideotimecode.c because drop-frame is not defined for any other frame rate (e.g. 24000/101) https://blog.frame.io/2017/07/17/timecode-and-frame-rates/
Created attachment 373482 [details] [review] decklink: Only use drop-frame flag for 29.97 and 59.94 FPS Otherwise it can cause errors in gstvideotimecode.c because drop-frame is not defined for any other frame rate (e.g. 24000/101) https://blog.frame.io/2017/07/17/timecode-and-frame-rates/
Review of attachment 373482 [details] [review]: ::: sys/decklink/gstdecklinkvideosrc.cpp @@ +760,3 @@ GST_VIDEO_TIME_CODE_FLAGS_INTERLACED); + if (bmode->fps_d == 1001) { + if (bmode->fps_n == 30000 || bmode->fps_n == 60000) These two framerates also exist non-drop-frame. Please add a comment here why we nonetheless always assume them to be drop-frame. Otherwise seems fine
Created attachment 373483 [details] [review] decklink: Only use drop-frame flag for 29.97 and 59.94 FPS Otherwise it can cause errors in gstvideotimecode.c because drop-frame is not defined for any other frame rate (e.g. 24000/101) https://blog.frame.io/2017/07/17/timecode-and-frame-rates/
Review of attachment 373483 [details] [review]: commit 4ca76e0c123b37175dd76057dbb45c96b47e7477 (HEAD -> upstream_master, upstream/master) Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Tue Aug 28 15:04:53 2018 +0300 decklink: Only use drop-frame flag for 29.97 and 59.94 FPS Otherwise it can cause errors in gstvideotimecode.c because drop-frame is not defined for any other frame rate (e.g. 24000/101) https://blog.frame.io/2017/07/17/timecode-and-frame-rates/ https://bugzilla.gnome.org/show_bug.cgi?id=797037