GNOME Bugzilla – Bug 796894
typefind: Add new gst_type_find_helper_get_range_full() that returns flow return
Last modified: 2018-08-02 07:59:30 UTC
See commit message
Created attachment 373220 [details] [review] typefind: Add new gst_type_find_helper_get_range_full() that returns flow return And make use of it in the typefind element. It's useful to distinguish between the different errors why typefinding can fail, and especially to not consider GST_FLOW_FLUSHING as an actual error.
gtk-doc chunk has some copy'n'pasted bits that are no longer true ("Returns:", "free-func: gst_caps_unref)
Created attachment 373222 [details] [review] typefind: Add new gst_type_find_helper_get_range_full() that returns flow return And make use of it in the typefind element. It's useful to distinguish between the different errors why typefinding can fail, and especially to not consider GST_FLOW_FLUSHING as an actual error.
(In reply to Tim-Philipp Müller from comment #2) > gtk-doc chunk has some copy'n'pasted bits that are no longer true > ("Returns:", "free-func: gst_caps_unref) Fixed that and also changed the error behaviour a bit. If during the loop we ever get an non-EOS error, we just exit early and don't return any caps at all (see comment in the code for reasoning).
Attachment 373222 [details] pushed as 41f1a40 - typefind: Add new gst_type_find_helper_get_range_full() that returns flow return