After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796878 - qtdemux: Only set width/height in caps if they're non-0
qtdemux: Only set width/height in caps if they're non-0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.14.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-26 19:27 UTC by Olivier Crête
Modified: 2018-10-19 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Only set width/height in caps if they're non-0 (1.32 KB, patch)
2018-07-26 19:28 UTC, Olivier Crête 		committed Details | Review
Slightly too big example file (517.65 KB, application/octet-stream)
2018-08-27 19:41 UTC, Olivier Crête 		  Details

Description Olivier Crête 2018-07-26 19:27:30 UTC 
There exist some files where it is set to 0, but the actual sizes can be retrieved from
the bitstream. FFmpeg can read and transmux them just fine into valid files by extracting
the resolution from the bistream, but we can't. By just not putting it into the caps, we can
make this "just work".
Comment 1 Olivier Crête 2018-07-26 19:28:55 UTC 
Created attachment 373174 [details] [review]
qtdemux: Only set width/height in caps if they're non-0

If they are not valid, then let a downstream parser complete them.
Comment 2 Nicolas Dufresne (ndufresne) 2018-07-26 19:43:24 UTC 
Review of attachment 373174 [details] [review]:

I agree with this one.
Comment 3 Nicolas Dufresne (ndufresne) 2018-07-26 19:43:46 UTC 
Seems like this could be worth a test.
Comment 4 Sebastian Dröge (slomo) 2018-07-27 07:37:09 UTC 
Makes sense, yes
Comment 5 Edward Hervey 2018-08-23 06:28:01 UTC 
Olivier, got such a (smallish) file we could add to the validate testsuite ?
Comment 6 Olivier Crête 2018-08-27 19:41:05 UTC 
Created attachment 373466 [details]
Slightly too big example file

Here is one such file, it's 500k, so not incredibly small. But if we have a smaller .mp4 file, we can craft one by setting the frame size to 0.
Comment 7 Edward Hervey 2018-10-19 12:20:32 UTC 
Attachment 373174 [details] pushed as 20d5f92 - qtdemux: Only set width/height in caps if they're non-0
Comment 8 Edward Hervey 2018-10-19 12:34:59 UTC 
Pushed to master and 1.14