After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796809 - rtppayload: Fix VP8/VP9/OPUS dual encoding name handling
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.14.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 796808 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-07-14 02:39 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-08-01 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling (5.40 KB, patch)
2018-07-14 02:40 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling (5.41 KB, patch)
2018-07-14 02:56 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2018-07-14 02:39:51 UTC 
See commit message. This fixes an assertion with the following pipelines:

gst-launch-1.0 \
        videotestsrc ! vp8enc ! rtpvp8pay ! rtpmux ! fakesink
        videotestsrc ! vp9enc ! rtpvp9pay ! rtpmux ! fakesink
        audiotestsrc ! opusenc ! rtpopuspay ! rtpmux ! fakesink
Comment 1 Nicolas Dufresne (ndufresne) 2018-07-14 02:40:05 UTC 
Created attachment 373054 [details] [review]
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling

All these were copy pasted and would lead to assertion when chained with
rtpmux. This commit rewrite the negotiation with downstream. This also
drop the fallback to ancient names if the pad is unlinked. This was
completly arbitrary decision that made no sense.
Comment 2 Nicolas Dufresne (ndufresne) 2018-07-14 02:56:13 UTC 
Created attachment 373055 [details] [review]
rtppayload: Fix VP8/VP9/OPUS dual encoding name handling

All these were copy pasted and would lead to assertion when chained with
rtpmux. This commit rewrite the negotiation with downstream. This also
drop the fallback to ancient names if the pad is unlinked. This was
completly arbitrary decision that made no sense.
Comment 3 Sebastian Dröge (slomo) 2018-07-14 04:27:13 UTC 
*** Bug 796808 has been marked as a duplicate of this bug. ***
Comment 4 Nicolas Dufresne (ndufresne) 2018-07-14 14:11:27 UTC 
Oops, git bz file froze and I didn't notice it was properly filed, thanks.
Comment 5 Sebastian Dröge (slomo) 2018-07-16 06:47:13 UTC 
Review of attachment 373055 [details] [review]:

Makes sense
Comment 6 Nicolas Dufresne (ndufresne) 2018-08-01 13:42:57 UTC 
Attachment 373055 [details] pushed as 2b11c62 - rtppayload: Fix VP8/VP9/OPUS dual encoding name handling
Comment 7 Nicolas Dufresne (ndufresne) 2018-08-01 13:48:59 UTC 
commit d4a8ec2fb4b133e11ec985a9dcf7859ddfed9d72 (HEAD -> 1.14)
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Fri Jul 13 22:31:04 2018 -0400

    rtppayload: Fix VP8/VP9/OPUS dual encoding name handling