After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796748 - rtph264pay: SPS/PPS is injected even if already present
rtph264pay: SPS/PPS is injected even if already present
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-03 21:13 UTC by Jan Alexander Steffens (heftig)
Modified: 2018-08-16 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtph264pay: Update last_spspps timestamp on idempotent SPS/PPS (1.10 KB, patch)
2018-07-03 21:15 UTC, Jan Alexander Steffens (heftig) 		none Details | Review
rtph26*pay: Update param set timestamp even if parameters unchanged (1.75 KB, patch)
2018-08-15 10:10 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2018-07-03 21:13:42 UTC 
With config-interval=1, duplicate SPS/PPS units are injected even if the IDR frame is already immediately preceded by such.
Comment 1 Jan Alexander Steffens (heftig) 2018-07-03 21:15:36 UTC 
Created attachment 372944 [details] [review]
rtph264pay: Update last_spspps timestamp on idempotent SPS/PPS

It seems that rtph264pay skips updating the last_spspps timestamp if the
units it gets contain no new configuration. This results in duplicate
injections.
Comment 2 Sebastian Dröge (slomo) 2018-08-15 09:42:53 UTC 
please do the same for h265 and other codecs with out-of-band + in-band codec data :)
Comment 3 Jan Alexander Steffens (heftig) 2018-08-15 10:10:23 UTC 
Created attachment 373339 [details] [review]
rtph26*pay: Update param set timestamp even if parameters unchanged

rtph264pay and rtph265pay skip updating the parameter set timestamp if
the units they see contain no new configuration. This can result in
them injecting duplicate parameters.

---

I looked through the payloaders having config-interval and only found
a similar problem in the H.265 code.
Comment 4 Sebastian Dröge (slomo) 2018-08-16 13:49:40 UTC 
Attachment 373339 [details] pushed as 2075821 - rtph26*pay: Update param set timestamp even if parameters unchanged