After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796727 - av1enc: fails to drain all frames on EOS
av1enc: fails to drain all frames on EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-01 09:02 UTC by Georg Ottinger
Modified: 2018-07-26 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Georg Ottinger 2018-07-01 09:02:21 UTC 
On my low end system (Celeron G3930, 4GB Ram, Sata SSD, Ubuntu 18.04)

i expirience problems when using av1enc.


gst-launch-1.0 videotestsrc num-buffers=1 ! av1enc cpu-used=2 ! webmmux ! filesink location=out.webm

Fails, meaning a corrupt out.webm (with 315 bytes size) is created. 

If I increase num-buffers - I get to the point (num-buffers=19) where things start working.

gst-launch-1.0 videotestsrc num-buffers=19 ! av1enc cpu-used=2 ! webmmux ! filesink location=out.webm

Where the produced out.webm holds a single frame.

num-buffers=20 -> results in two frames and so on 

It seems that the first 18 frames don't make it on time on my system.
Comment 1 Sebastian Dröge (slomo) 2018-07-02 10:25:31 UTC 
This would mean that av1enc does not properly drain on EOS

Maybe Sean has an idea what the problem could be?
Comment 2 Olivier Crête 2018-07-26 14:34:58 UTC 
Fixed:

commit 7c2170a63a442aa4bc06a6511cc29bd56b77da8c
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Thu Jul 26 09:55:48 2018 -0400

    av1enc: Implement finish for EOS
    
    Call the encode function repeatedly until nothing comes out.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796727