After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796725 - player: Clear external subtitle uri before selecting in-band text track
player: Clear external subtitle uri before selecting in-band text track
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-30 15:52 UTC by Philippe Normand
Modified: 2018-11-03 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (967 bytes, patch)
2018-06-30 15:54 UTC, Philippe Normand 		needs-work Details | Review

Description Philippe Normand 2018-06-30 15:52:24 UTC 
See commit message.
Comment 1 Philippe Normand 2018-06-30 15:54:06 UTC 
Created attachment 372899 [details] [review]
patch
Comment 2 Philippe Normand 2018-06-30 18:59:41 UTC 
Review of attachment 372899 [details] [review]:

::: gst-libs/gst/player/gstplayer.c
@@ +3923,3 @@
   }
 
+  gst_player_set_subtitle_uri (self, NULL);

This is racy... :/
Comment 3 Sebastian Dröge (slomo) 2018-07-02 10:27:33 UTC 
Doesn't it have the external and all internals available for selection via the input-selector then? Doesn't it just appear as yet another subtitle stream?
Comment 4 GStreamer system administrator 2018-11-03 14:27:04 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/742.