After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796651 - protection: factory list leak in gst_protection_filter_systems_by_available_decryptors()
protection: factory list leak in gst_protection_filter_systems_by_available_d...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-22 14:35 UTC by Philippe Normand
Modified: 2018-06-25 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.19 KB, patch)
2018-06-22 14:54 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2018-06-22 14:35:27 UTC 
The list is not freed if the function returns early. Attaching patch...
Comment 1 Philippe Normand 2018-06-22 14:37:34 UTC 
False alarm :P
Comment 2 Philippe Normand 2018-06-22 14:54:03 UTC 
Created attachment 372776 [details] [review]
patch
Comment 3 Thibault Saunier 2018-06-22 15:50:30 UTC 
Lgtm, why:

(In reply to Philippe Normand from comment #1)
> False alarm :P

:-)
Comment 4 Philippe Normand 2018-06-22 15:57:14 UTC 
(In reply to Thibault Saunier from comment #3)
> Lgtm, why:
> 
> (In reply to Philippe Normand from comment #1)
> > False alarm :P
> 
> :-)

Fridays ;)
Comment 5 Thibault Saunier 2018-06-25 15:25:52 UTC 
Review of attachment 372776 [details] [review]:

Go then.
Comment 6 Philippe Normand 2018-06-25 15:48:59 UTC 
commit cc55b304ef4ab1cd95f6348d33f268ccebaab8e8 (HEAD -> master, origin/master, origin/HEAD)
Author: Philippe Normand <philn@igalia.com>
Date:   Fri Jun 22 15:35:42 2018 +0100

    protection: Release decryptors list, even if it's empty
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796651