After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796567 - matroskademux: exposes mis-named embedded subtitle track
matroskademux: exposes mis-named embedded subtitle track
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-12 11:30 UTC by Philippe Normand
Modified: 2018-06-30 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
matroskademux log file (157.89 KB, application/gzip)
2018-06-12 11:30 UTC, Philippe Normand 		  Details
patch (1.09 KB, patch)
2018-06-13 16:43 UTC, Philippe Normand 		reviewed Details | Review
updated patch (1.09 KB, patch)
2018-06-14 18:05 UTC, Philippe Normand 		none Details | Review
patch (1.10 KB, patch)
2018-06-29 16:17 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2018-06-12 11:30:03 UTC 
Created attachment 372657 [details]
matroskademux log file

I have a mkv file with an English subtitles track and an English SDH subtitles track. The TrackName is actually correct for both tracks in matroskademux but on application side both track labels are English, which is a bit confusing, perhaps because the language-code is the same for both tracks?

Attaching log file.
Comment 1 Philippe Normand 2018-06-13 16:43:40 UTC 
Created attachment 372675 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2018-06-14 08:17:45 UTC 
Comment on attachment 372675 [details] [review]
patch

But it can also contain more than just the language, or not? And something completely different.

Not sure, it probably is better in most cases but might be completely wrong in others. Maybe instead the name should end up in the title, and applications should also look at the title?
Comment 3 Philippe Normand 2018-06-14 09:50:42 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 372675 [details] [review] [review]
> patch
> 
> But it can also contain more than just the language, or not? And something
> completely different.

Right... good point :)

> 
> Not sure, it probably is better in most cases but might be completely wrong
> in others. Maybe instead the name should end up in the title, and
> applications should also look at the title?

Just making sure I understand, that would mean gst-player first looks for GST_TAG_TITLE (todo), then LANGUAGE_NAME, then LANGUAGE_CODE ?
Comment 4 Philippe Normand 2018-06-14 18:05:33 UTC 
Created attachment 372687 [details] [review]
updated patch
Comment 5 Thibault Saunier 2018-06-29 14:18:24 UTC 
Review of attachment 372675 [details] [review]:

This commit message doesn't match what the code does to me. You basically make sure that the track name is expoxed to the user here iiuc.
Comment 6 Philippe Normand 2018-06-29 16:17:01 UTC 
Created attachment 372887 [details] [review]
patch

Reworded commit message.
Comment 7 Thibault Saunier 2018-06-29 16:18:35 UTC 
Review of attachment 372887 [details] [review]:

lgtm
Comment 8 Philippe Normand 2018-06-30 15:59:15 UTC 
commit 4c10a1ba27ca44450ab76c239de2a218358418e3 (HEAD -> master, origin/master, origin/HEAD)
Author: Philippe Normand <philn@igalia.com>
Date:   Wed Jun 13 17:39:57 2018 +0100

    matroskademux: Set subtitle tag title from TrackName field
    
    GUI applications can then use the title tag to set menu items or labels
    representing the track.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796567