After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796563 - sdp: Add new constructor, sdp_message_from_text
sdp: Add new constructor, sdp_message_from_text
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-11 16:33 UTC by Mathieu Duponchelle
Modified: 2018-06-12 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sdp: Add new constructor, sdp_message_from_text (2.36 KB, patch)
2018-06-11 16:33 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2018-06-11 16:33:21 UTC
See commit message
Comment 1 Mathieu Duponchelle 2018-06-11 16:33:28 UTC
Created attachment 372636 [details] [review]
sdp: Add new constructor, sdp_message_from_text
Comment 2 Nirbheek Chauhan 2018-06-11 16:39:12 UTC
Review of attachment 372636 [details] [review]:

lgtm, although you might want to mention why exactly this is needed.
Comment 3 Nicolas Dufresne (ndufresne) 2018-06-11 17:11:00 UTC
Review of attachment 372636 [details] [review]:

There is a win32 def file that still need to be updated.

::: gst-libs/gst/sdp/gstsdpmessage.c
@@ +244,3 @@
+ * Parse @text and create a new SDPMessage from these.
+ *
+ * Returns: a #GstSDPResult.

Since marker is missing.
Comment 4 Mathieu Duponchelle 2018-06-11 18:21:25 UTC
Attachment 372636 [details] pushed as a4a27fd - sdp: Add new constructor, sdp_message_from_text
Comment 5 Tim-Philipp Müller 2018-06-11 18:24:33 UTC
Did you choose _new_from_text() on purpose, vs. the more common _new_from_string() ?
Comment 6 Mathieu Duponchelle 2018-06-12 17:12:34 UTC
(In reply to Tim-Philipp Müller from comment #5)
> Did you choose _new_from_text() on purpose, vs. the more common
> _new_from_string() ?

I did yes, there's an as_text() method in GstSDPMessage

(In reply to Nicolas Dufresne (ndufresne) from comment #3)
> Review of attachment 372636 [details] [review] [review]:
> 
> There is a win32 def file that still need to be updated.

There's no def file in -base

> 
> ::: gst-libs/gst/sdp/gstsdpmessage.c
> @@ +244,3 @@
> + * Parse @text and create a new SDPMessage from these.
> + *
> + * Returns: a #GstSDPResult.
> 
> Since marker is missing.

Ah, I hadn't updated the patch here it seems, the commited version has the marker :)