After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796399 - vaapipostproc: don't copy the GstParentBufferMeta if use_vpp
vaapipostproc: don't copy the GstParentBufferMeta if use_vpp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-25 14:53 UTC by Michael Olbrich
Modified: 2018-06-07 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapipostproc: don't copy the GstParentBufferMeta if use_vpp (1.04 KB, patch)
2018-05-25 14:53 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2018-05-25 14:53:27 UTC 
I've noticed that DMABuf input buffer for vaapipostproc are still
referenced long after vaapipostproc is done processing. This happens
because the GstParentBufferMeta is copied to the output buffer.

At least for vpp this should not be needed. I'm not sure about the other
modes so I've restriced this to use_vpp == true here.
Comment 1 Michael Olbrich 2018-05-25 14:53:33 UTC 
Created attachment 372400 [details] [review]
vaapipostproc: don't copy the GstParentBufferMeta if use_vpp

Otherwise a reference to a DMABuf input buffer is kept until the output
buffer is deleted.
Comment 2 Víctor Manuel Jáquez Leal 2018-06-07 09:54:28 UTC 
Review of attachment 372400 [details] [review]:

lgtm
Comment 3 Víctor Manuel Jáquez Leal 2018-06-07 10:39:28 UTC 
Attachment 372400 [details] pushed as d79bda3 - vaapipostproc: don't copy the GstParentBufferMeta if use_vpp