After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796379 - flvmux: (too) easily produces backwards flv-timestamps
flvmux: (too) easily produces backwards flv-timestamps
Status: RESOLVED DUPLICATE of bug 796382
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal blocker
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-24 10:09 UTC by Håvard Graff (hgr)
Modified: 2018-05-24 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Håvard Graff (hgr) 2018-05-24 10:09:27 UTC
Running the new GstAggregator-based flvmuxer in our system gave some weird failures.

Turns out it was caused by the flv-timestamps going backwards, and with RTMP generating delta timestamps, these would go negative and cause the timestamps
to overflow, producing timestamps thousands of hours into the future!

With a bit of hassle I was able to produce a test that can be run both with the
old and new flvmuxer, and that will produce a "correct" sequence with the old implmentation, and a "backwards-timestamp" sequence with the new, basing it on
the real data I saw in our tests.

As for possible fixes I think first it would be a good idea to determine if
producing backwards timestamps in the flv-stream is something we want to avoid
at all costs, or if this can be expected to happen.

Anyway, some sort of sanity internally in the flvmuxer to at least notify the
user of backwards timestamps (or perhaps a property to not allow it), would probably be a good idea, as I expect many people upgrading the muxer would experience similar things to what we did.
Comment 1 Nicolas Dufresne (ndufresne) 2018-05-24 12:14:07 UTC
Can you clarify, FLV format is delta based, so backward timestamp are not possible. Do you mean the timestamps on the buffers are going backward ? Do you mean PTS or DTS ?
Comment 2 Nicolas Dufresne (ndufresne) 2018-05-24 12:15:03 UTC
Hmm, just notice your marked this new bug as obsolete .... confusing, but oh well.
Comment 3 Nicolas Dufresne (ndufresne) 2018-05-24 12:16:17 UTC

*** This bug has been marked as a duplicate of bug 796382 ***