Created attachment 372326 [details] [review]
waylandsink: don't check if buffer used by compositor when attach

Review of attachment 372326 [details] [review]:

Would be nice to show in your comment message your analyses that explain that this case is legal and is not a bug elswhere in the resize code.

(In reply to Nicolas Dufresne (ndufresne) from comment #2)
> Review of attachment 372326 [details] [review] [review]:
> 
> Would be nice to show in your comment message your analyses that explain
> that this case is legal and is not a bug elswhere in the resize code.

Hi, sorry for late response. We found we still need check this boolean. But could we not use g_return_if_fail, Because it will report error log.

Can we just add some check and return:

-  g_return_if_fail (self->used_by_compositor == FALSE);
+  if (self->used_by_compositor) {
+    GST_DEBUG_OBJECT (self, "buffer used by compositor %p", self->gstbuffer);
+    return;
+  }

Created attachment 373957 [details] [review]
wayland/wlbuffer: just return if used_by_compositor is true when attach

Review of attachment 373957 [details] [review]:

There is description in the commit message.

(In reply to Nicolas Dufresne (ndufresne) from comment #5)
> Review of attachment 373957 [details] [review] [review]:
> 
> There is description in the commit message.

? description for what? I mean could we use the update patch check used_by_compositor instead of g_retrun_if_fail

(In reply to Nicolas Dufresne (ndufresne) from comment #5)
> Review of attachment 373957 [details] [review] [review]:
> 
> There is description in the commit message.

? description for what? I mean could we use the update patch check used_by_compositor instead of g_retrun_if_fail

I means to write "this is no description", meant to be a code review comment. Please add a description to your commits that explains why you make this change. The original author thought it was a programming error, so you should explain why it's not.

Created attachment 373968 [details] [review]
wayland/wlbuffer: just return if used_by_compositor is true when attach (V2)

(In reply to Nicolas Dufresne (ndufresne) from comment #8)
> I means to write "this is no description", meant to be a code review
> comment. Please add a description to your commits that explains why you make
> this change. The original author thought it was a programming error, so you
> should explain why it's not.

Update.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/712.