After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796325 - meson: Add exception for atomic ops test for Android
meson: Add exception for atomic ops test for Android
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-05-22 06:17 UTC by Nirbheek Chauhan
Modified: 2018-05-22 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: Add exception for atomic ops test for Android (1.82 KB, patch)
2018-05-22 06:18 UTC, Nirbheek Chauhan 		none Details | Review
meson: Add exception for atomic ops test for Android (1.81 KB, patch)
2018-05-22 06:27 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2018-05-22 06:17:51 UTC 
This fixes a build failure with meson on Android armv5 which doesn't happen with Autotools.
Comment 1 Nirbheek Chauhan 2018-05-22 06:18:00 UTC 
Created attachment 372324 [details] [review]
meson: Add exception for atomic ops test for Android

Some compilers, particularly Android on armv5 and old versions of Clang
provide atomic ops, but don't define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
so we need to define it ourselves.

This matches what configure does, with the exception that now it's only
done for Android since clang defines __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4
now.
Comment 2 Nirbheek Chauhan 2018-05-22 06:27:59 UTC 
Created attachment 372325 [details] [review]
meson: Add exception for atomic ops test for Android

Fixed a typo in the previous patch.
Comment 3 Philip Withnall 2018-05-22 08:54:46 UTC 
Review of attachment 372325 [details] [review]:

++
Comment 4 Nirbheek Chauhan 2018-05-22 09:09:03 UTC 
Attachment 372325 [details] pushed as 74af384 - meson: Add exception for atomic ops test for Android