GNOME Bugzilla – Bug 796324
Safe browsing is broken
Last modified: 2018-06-13 19:41:06 UTC
Epiphany is creating a 45 kB gsb-threats.db instead of the full one. There aren't any changes to the code that could possibly have broken this, so I assume something has changed on Google's end. sqlitebrowser indicates nothing is present in the database. I'd like to check if we've used up our API quota, do we have a way to investigate this? I'm disabling the gsb test so that I can release. When we've fixed this, we'll need to reenable it.
We're hitting our "other requests" safe browsing API quota. We have unlimited quota for the update API, but a 10,000 requests/day limit for "other requests." Gabriel says: I believe this is the request that is considered as "other": https://developers.google.com/safe-browsing/v4/reference/rest/v4/threatLists/list Epiphany uses only three requests: threatLists.list, threatListUpdates.fetch, fullHashes.find. The last two are listed as part of the Update API (https://developers.google.com/safe-browsing/v4/lists) for which we have unlimited quota.
We probably have to again use this form https://docs.google.com/forms/d/e/1FAIpQLScMx4B_Q_bEPy7fjM866uqHmizlH1sUdrqJs12KOwyXjj912w/viewform. But I miss the "other requests" API type. Maybe we can ask for help on antiphish-malware-cap-req at google.com as it's written in the form.
(In reply to Tomas Popela from comment #2) > We probably have to again use this form > https://docs.google.com/forms/d/e/ > 1FAIpQLScMx4B_Q_bEPy7fjM866uqHmizlH1sUdrqJs12KOwyXjj912w/viewform. But I > miss the "other requests" API type. Maybe we can ask for help on > antiphish-malware-cap-req at google.com as it's written in the form. I've submitted a request using the form: """ Hi, the open source GNOME web browser (Epiphany) already has unlimited quota for the Update API (thank you for that!) but we are hitting the 10,000 request quota for "other requests" because of the threatLists.list request, which is counted for the "other requests" quota rather than the Update API quota. Since you've already kindly granted us the unlimited Update API quota, perhaps we could have that for "other requests" as well? Thanks a bunch! (Reference: https://bugzilla.gnome.org/show_bug.cgi?id=796324 and https://bugzilla.gnome.org/show_bug.cgi?id=796364.) """ I assume it will be handled by a human, so hopefully it will work. If I don't hear back by next Wednesday, I'll mail antiphish-malware-cap-req@.
Almost forgot about this. They never replied. So we need to mail antiphish-malware-cap-req@ and hope a human is watching that. Gabriel, would you like to handle this? If not, I can certainly send the mail.
Um, forgot about this again. OK. Mailing the list now.
Fixed now. We got our quota increase from Google, and also learned that we were not supposed to be calling this method anyway. Gabriel has removed its use now.