After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796274 - meson: Various fixes (MSYS2)
meson: Various fixes (MSYS2)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.14.0
Other Linux
: Normal normal
: 1.14.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-20 12:01 UTC by Christoph Reiter (lazka)
Modified: 2018-05-20 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: Fix detection of glib-mkenums under MSYS2 (3.90 KB, patch)
2018-05-20 12:02 UTC, Christoph Reiter (lazka)
committed Details | Review
meson: install license-translations.dict and set LICENSE_TRANSLATIONS_PATH (1.43 KB, patch)
2018-05-20 12:02 UTC, Christoph Reiter (lazka)
committed Details | Review
meson: install the man pages (1.15 KB, patch)
2018-05-20 12:02 UTC, Christoph Reiter (lazka)
committed Details | Review
meson: remove non-headers from gl_prototype_headers (929 bytes, patch)
2018-05-20 12:03 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Christoph Reiter (lazka) 2018-05-20 12:01:07 UTC
Some things I've noticed while moving the package in MSYS2 to meson, not strictly MSYS2 related. It would be nice if they would be considered for 1.14.x
Comment 1 Christoph Reiter (lazka) 2018-05-20 12:02:04 UTC
Created attachment 372236 [details] [review]
meson: Fix detection of glib-mkenums under MSYS2

Under MSYS2 glib-mkenums is an executable and has a .exe extension and
the path does not end with "glib-mkenums".

Make the script compare the path without the file extension instead.

----

The scripts are gone in master, so this is for 1.14 only.
Comment 2 Christoph Reiter (lazka) 2018-05-20 12:02:33 UTC
Created attachment 372237 [details] [review]
meson: install license-translations.dict and set  LICENSE_TRANSLATIONS_PATH

The autotools build installs the file and sets the LICENSE_TRANSLATIONS_PATH
macro which licences.c uses as a fallback path. Do the same with meson.
Comment 3 Christoph Reiter (lazka) 2018-05-20 12:02:55 UTC
Created attachment 372238 [details] [review]
meson: install the man pages
Comment 4 Christoph Reiter (lazka) 2018-05-20 12:03:22 UTC
Created attachment 372239 [details] [review]
meson: remove non-headers from gl_prototype_headers

This made the meson build install those files, while they aren't
installed with the autotools build.
Comment 5 Christoph Reiter (lazka) 2018-05-20 12:03:59 UTC
That's it :)
Comment 6 Tim-Philipp Müller 2018-05-20 13:40:03 UTC
commit 39e1dd0bbf053886704b721fa8d13f79976ac98a
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun May 20 14:27:18 2018 +0100

    meson: add 'nls' option to disable translations
    
    And enable by default. Was implicitly disabled because
    ENABLE_NLS was not defined.

commit eef72d0d85408a03fd894bcf81c63348001cbb5a
Author: Christoph Reiter <reiter.christoph@gmail.com>
Date:   Sun May 20 13:33:13 2018 +0200

    meson: install license-translations.dict and set LICENSE_TRANSLATIONS_PATH
    
    The autotools build installs the file and sets the LICENSE_TRANSLATIONS_PATH
    macro which licences.c uses as a fallback path. Do the same with meson.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796274

commit b163f373c393f40a1128eced538e1e947ef51b87
Author: Christoph Reiter <reiter.christoph@gmail.com>
Date:   Sun May 20 13:35:52 2018 +0200

    meson: install the man pages for the command line tools
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796274
Comment 7 Tim-Philipp Müller 2018-05-20 13:42:23 UTC
Comment on attachment 372239 [details] [review]
meson: remove non-headers from gl_prototype_headers

commit 103f884d99a96c1d20546ff625b046bff5252cb7
Author: Christoph Reiter <reiter.christoph@gmail.com>
Date:   Sun May 20 13:37:07 2018 +0200

    meson: gl: remove non-headers from gl_prototype_headers
    
    This made the meson build install those files, while they aren't
    installed with the autotools build.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796274
Comment 8 Tim-Philipp Müller 2018-05-20 15:49:57 UTC
Comment on attachment 372236 [details] [review]
meson: Fix detection of glib-mkenums under MSYS2

Thanks!

commit 9250eb884d13b7f27ba4d4a053552f495cfa4eb5 (HEAD -> 1.14)
Author: Christoph Reiter <reiter.christoph@gmail.com>
Date:   Sun May 20 13:40:37 2018 +0200

    meson: Fix detection of glib-mkenums under MSYS2
    
    Under MSYS2 glib-mkenums is an executable and has a .exe extension and
    the path does not end with "glib-mkenums".
    
    Make the script compare the path without the file extension instead.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796274