After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796208 - Meson: Missing flags on MacOSX
Meson: Missing flags on MacOSX
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 790954
 
 
Reported: 2018-05-17 14:23 UTC by Xavier Claessens
Modified: 2018-05-24 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Meson: Remove FIXME about missing checks for macosx <= 10.3 (881 bytes, patch)
2018-05-24 13:33 UTC, Xavier Claessens 		none Details | Review

Description Xavier Claessens 2018-05-17 14:23:33 UTC 
While checking the .pc file generated for macosx using autotools, I noticed it has those flags that meson won't add: -Wl,-framework -Wl,CoreFoundation. It comes from glib-gettext.m4.
Comment 1 Xavier Claessens 2018-05-23 18:54:33 UTC 
That flag got added in bug #796214 attachment #372194 [details].
Comment 2 Philip Withnall 2018-05-24 10:14:18 UTC 
Mmm, but it was added with a FIXME. Let’s track fixing the FIXME in this bug.

```
# FIXME: Should this be conditional? glib-gettext.m4 has some checks
```
Comment 3 Xavier Claessens 2018-05-24 13:30:18 UTC 
It's in glib_gt_INTL_MACOSX:
dnl Check for API introduced in Mac OS X 10.2.
dnl Check for API introduced in Mac OS X 10.3.

I think we depend on newer version than that anyway, right?
Comment 4 Xavier Claessens 2018-05-24 13:33:24 UTC 
Created attachment 372386 [details] [review]
Meson: Remove FIXME about missing checks for macosx <= 10.3

Our minimum requirement is already greater than that, so we don't need
to add checks there. We can always add -Wl,-framework,CoreFoundation
flag.
Comment 5 GNOME Infrastructure Team 2018-05-24 20:33:27 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1380.