After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796093 - gstmodule: fix warning
gstmodule: fix warning
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other All
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-14 08:15 UTC by Håvard Graff (hgr)
Modified: 2018-05-14 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstmodule: fix warning (854 bytes, patch)
2018-05-14 08:15 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2018-05-14 08:15:39 UTC
Created attachment 371990 [details] [review]
gstmodule: fix warning

PyMapping_GetItemString’ discards ‘const’ qualifier from pointer target type
Comment 1 Thibault Saunier 2018-05-14 11:30:47 UTC
Review of attachment 371990 [details] [review]:

I am not getting that warning and can't see where/how it could happen, can you show the whole warning please?
Comment 2 Håvard Graff (hgr) 2018-05-14 11:49:23 UTC
(In reply to Thibault Saunier from comment #1)
> Review of attachment 371990 [details] [review] [review]:
> 
> I am not getting that warning and can't see where/how it could happen, can
> you show the whole warning please?

  CC       _gi_gst_la-gstmodule.lo
/home/havard/Code/pexnote/external/gstreamer/gst-python/gi/overrides/gstmodule.c: In function ‘gi_gst_get_type’:
/home/havard/Code/pexnote/external/gstreamer/gst-python/gi/overrides/gstmodule.c:93:41: warning: passing argument 2 of ‘PyMapping_GetItemString’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   return PyMapping_GetItemString (dict, type_name);
                                         ^
In file included from /usr/include/python2.7/Python.h:133:0,
                 from /home/havard/Code/pexnote/external/gstreamer/gst-python/gi/overrides/gstmodule.c:29:
/usr/include/python2.7/abstract.h:1356:29: note: expected ‘char *’ but argument is of type ‘const gchar * {aka const char *}’
      PyAPI_FUNC(PyObject *) PyMapping_GetItemString(PyObject *o, char *key);
                             ^
  CCLD     _gi_gst.la
Comment 3 Thibault Saunier 2018-05-14 11:53:38 UTC
Pushed with a minor change in the commit message (specifying the issue was happening only with py2).