After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796090 - (wrong) true-color preview of GEGL filter ops, like gaussian blur in indexed mode
(wrong) true-color preview of GEGL filter ops, like gaussian blur in indexed ...
Status: RESOLVED DUPLICATE of bug 787237
Product: GEGL
Classification: Other
Component: babl
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2018-05-14 07:53 UTC by rich
Modified: 2018-05-17 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description rich 2018-05-14 07:53:45 UTC
Gimp 2.10.0 GEGL Rotate Colors Colors -> Map -> Rotate Colors can be used on a color indexed image. This can result in a different result from the filter preview.

Preview should mirror the result or more probably the filter should be disabled in the menu as in Gimp 2.8
Comment 1 Øyvind Kolås (pippin) 2018-05-14 08:30:45 UTC
gaussian blur and other filters *used* to show previews in the limited indexed palette associated with the image earlier in the 2.9 cycle.

Rather than disabling the ops in the menus, we should figure out how to return to the old behavior - at least for indexed mode - perhaps it is related to "fade" or split-preview handling, all different pixel modes - grayscale/rgb/indexed/8bpc/16bpc and float are all handled generically by all filters and now even gives anti-aliasing when doing things like merging down text-layers.
Comment 2 Michael Natterer 2018-05-16 00:13:58 UTC
Fixed in master, moving to babl for making it fast :)

commit d6e0ca505440596e81593cf9ec0fac4f0d9e2ba8
Author: Michael Natterer <mitch@gimp.org>
Date:   Wed May 16 02:06:03 2018 +0200

    Bug 796090 - (wrong) true-color preview of GEGL filter ops, ...
    
    ...like gaussian blur in indexed mode
    
    In GimpDrawable's source node, after the filter stack, insert a node
    that converts the pixels back to the drawable's format if the drawable
    is indexed.

 app/core/gimpdrawable-private.h |  1 +
 app/core/gimpdrawable.c         | 45 +++++++++++++++++++++++++++++++++++------
 2 files changed, 40 insertions(+), 6 deletions(-)
Comment 3 Øyvind Kolås (pippin) 2018-05-16 11:36:20 UTC
commit 9596cfe90b684f08abf678bcd0f7d6f13866ca6e
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Wed May 16 13:13:26 2018 +0200

    babl: preliminary work to add float fast path to palette formats
    
    Still not accurate enough to be acceptable, gets accepted by system with
    a BABL_TOLERANCE of 0.045 or higher. Needs more work.
Comment 4 Øyvind Kolås (pippin) 2018-05-17 08:02:09 UTC
Marking as duplicate of other missing fast-path bug, since that is what this bug is reduced to now.

*** This bug has been marked as a duplicate of bug 787237 ***